Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Creates the Person module and refactors a little #415

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

panoramix360
Copy link
Collaborator

This PR creates the Person Module and refactors to use the method created.

@nelsonic can you give some feedback if that's what you intended?

I searched on the code for other places that were using person-related stuff but the only thing that made sense to add on the module was this method.

Thank you!

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #415 (72e8660) into main (43404ee) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #415   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        20    +1     
  Lines          525       524    -1     
=========================================
- Hits           525       524    -1     
Files Changed Coverage Δ
lib/app/person.ex 100.00% <100.00%> (ø)
lib/app_web/controllers/tag_controller.ex 100.00% <100.00%> (ø)
lib/app_web/live/app_live.ex 100.00% <100.00%> (ø)
lib/app_web/live/stats_live.ex 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks. 👌

@nelsonic nelsonic merged commit 699e6cc into main Sep 6, 2023
@nelsonic nelsonic deleted the chore/refactor-get-person-id branch September 6, 2023 05:12
nelsonic added a commit that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants