Add "create tag" in select input #222
Conversation
Create a tag from the select input Feel free to discard this commit/PR see: #221
| @@ -85,6 +85,11 @@ | |||
| </div> | |||
| </li> | |||
| <% end %> | |||
| <%= if Enum.empty?(@tags) and String.length(String.trim(@search_tag)) != 0 do %> | |||
There was a problem hiding this comment.
Only show the "create" action when the search for a tag returns 0 results
run mix format
|
@SimonLab feels like we need "review apps" to discuss ... dwyl/learn-devops#85 💭 |
|
Yes I will look at how we can create review apps with Fly. |
SimonLab
added
the
discuss
|
Clicking on the "create my new tag" will create the tag and select it before resetting the search tag input: |
|
The concept of having to manually "Create new tag" is a UX antipattern that takes the person out of the flow of "Capture" mode and into "admin". We aren't going to do this as outlined in: #221 (comment) |
|
To clarify if we need to search code from this PR, the feature added here doesn't redirect to another page. The create link call some liveview code which creates the tag and update the UI with the tag pill |
Please feel free to discard/close this PR, see #221 (comment)
It is in example how a tag can be created from the select input.
As mentioned in the issue, this is not a prefect UX, this PR can be used for testing and discussion.