-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Making variables "snake_case" in drag and drop code #419
Conversation
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 599 599
=========================================
Hits 599 599
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Should be mergeable 🆗 |
Hi @LuchoTurtle the only reason I didn't merge this immediately is that it will create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the target branch to items-list
and confirmed no merge-conflicts
. ✅
Thanks again for updating the variable names. 🙏
Merging.
closes #416
This renames events and variables in
assets/js/app.js
,lib/app_web/live/app_live.ex
andlib/app_web/live/app_live.html.heex
, as well as the respective tests.BUILDIT.md
has also been modified according to these changes.