PR: Simplify MVP + Update to Phoenix 1.6 #89 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonic
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 7 -12
Lines 167 131 -36
=========================================
- Hits 167 131 -36
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
28 tasks
|
@SimonLab I feel this is now in a reviewable state. (Hope you agree ... 🤞 ) |
nelsonic
added
awaiting-review
nelsonic
changed the title
SimonLab
reviewed
Aug 8, 2022
…dance! dwyl/dev-setup#45 ...] Co-authored-by: Simon <simon.labondance@gmail.com>
This was referenced Aug 8, 2022
Closed
SimonLab
approved these changes
Aug 9, 2022
| @@ -1,5 +1,4 @@ | |||
| export ALLOW_API_ORIGINS=* | |||
There was a problem hiding this comment.
I'm not sure if we use this env?
There was a problem hiding this comment.
Nope it's a remnant from the previous version where we had an API and a Frontend UI. 👍
Feel free to remove when you are doing your work. #119
| @impl true | ||
| def mount(_params, _session, socket) do | ||
| # subscribe to the channel | ||
| if connected?(socket), do: AppWeb.Endpoint.subscribe(@topic) |
There was a problem hiding this comment.
I'll do some research and write somwhere when to use Endpoint vs PubSub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a re-write of the app to use the
PETALStack. 🚀The bulk of the code is in
LiveViewto facilitate realtime interactions between devices. 😍There isn't very much code ... scroll down to the CodeCov comment ...
131 linesof (relevant) code. 🤯Most of the changes in this PR are docs/comments. 📜
Details in the
Epic#89 ⛰️The code + tutorial is split into a separate file:
BUILDIT.md(I didn't have a better name ... feel free to re-name if you do!)Thanks. 👌