Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Github section to style guide #4

Merged
merged 7 commits into from
Aug 15, 2015
Merged

Adds Github section to style guide #4

merged 7 commits into from
Aug 15, 2015

Conversation

iteles
Copy link
Member

@iteles iteles commented Aug 11, 2015

Adds sections on:

  • Writing issues
  • Writing commit messages
  • Writing pull requests
  • Naming repos

Fixes #2

@iteles
Copy link
Member Author

iteles commented Aug 15, 2015

@nelsonic Please take a look and make any amendments 😊 Thanks!


###Pull Requests
Good pull requests (PR) reduce the back and forth required between the person submitting the PR and the assigned reviewer, saving everyone time.
+ Before submitting a PR, **open a new issue** so you can _confirm the need_ for the functionality you are intending to add (like in [this example](https://github.com/dshaw/env/issues/6))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this PR: indexzero/ps-tree#12

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to the correct issue 👍

@nelsonic
Copy link
Member

Thanks @iteles
Great start! 👍

nelsonic added a commit that referenced this pull request Aug 15, 2015
Adds Github section to style guide
@nelsonic nelsonic merged commit 598f49f into master Aug 15, 2015
@nelsonic nelsonic deleted the git branch August 15, 2015 22:37
Cleop pushed a commit that referenced this pull request May 25, 2017
Creates first draft of readme based on outline in issue #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants