Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Calendar dates and times #45

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

bonf
Copy link
Contributor

@bonf bonf commented Mar 30, 2023

Hi, this PR adds support for Calendar dates and times,
to avoid this kind of error:

** (Protocol.UndefinedError) protocol Enumerable not implemented for ~N[2023-03-30 12:00:00] of type NaiveDateTime (a struct)

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #45 (a8e2022) into main (0450a89) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           39        43    +4     
=========================================
+ Hits            39        43    +4     
Impacted Files Coverage Δ
lib/useful.ex 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bonf Good idea to explicitly pattern match these to avoid errors. 👌

@nelsonic nelsonic merged commit a3c040f into dwyl:main Mar 30, 2023
@nelsonic
Copy link
Member

Package published to https://hex.pm/packages/useful/1.11.0 contains this update. 📦
Thanks again @bonf 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants