Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for %Plug.Upload{} #49

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Add support for %Plug.Upload{} #49

merged 1 commit into from
Aug 10, 2023

Conversation

icr4
Copy link
Contributor

@icr4 icr4 commented Aug 10, 2023

This PR adds support for Plug.Upload to avoid this kind of error:

(Protocol.UndefinedError) protocol Enumerable not implemented for %Plug.Upload{}

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #49 (a3a973f) into main (3590fe9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           44        45    +1     
=========================================
+ Hits            44        45    +1     
Files Changed Coverage Δ
lib/useful.ex 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icr4 thanks for adding this test case & function definition. 👌

@nelsonic
Copy link
Member

@icr4 Package published to https://hex.pm/packages/useful/1.12.0 📦 🚀 Thanks again. 🙏

nelsonic added a commit that referenced this pull request Aug 15, 2023
@nelsonic
Copy link
Member

Introduced a compilation error: #52 which is fixed by making Plug a dependency: #53

@icr4
Copy link
Contributor Author

icr4 commented Oct 25, 2023

I noticed this too late.
Thank you for fixing it

@nelsonic
Copy link
Member

@icr4 no worries. was a quick fix. thanks again. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants