Fix broken CI and unit tests #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prettymuchbryce
commented
Feb 2, 2023
| @@ -19,7 +19,8 @@ func IsClobOrderTransaction( | |||
| return false | |||
| } | |||
|
|
|||
| if len(cosmosTx.Body.Messages) == 1 && | |||
| if cosmosTx.Body != nil && | |||
There was a problem hiding this comment.
This was potentially a bug that could have caused panics.
There was a problem hiding this comment.
nice catch! in what case can the body be empty? is it possible to send an empty body tx?
There was a problem hiding this comment.
I am not sure if it's possible in practice, but this was happening in unit tests. It seems best to be defensive here.
BrendanChou
approved these changes
Feb 2, 2023
ttl33
reviewed
Feb 2, 2023
| @@ -582,6 +584,11 @@ func TestEndBlockValidatorUpdatesResultingInEmptySet(t *testing.T) { | |||
| {PubKey: vp, Power: 0}, | |||
| } | |||
|
|
|||
| // dYdX fork: Apply block should lock/unlock the mempool. | |||
There was a problem hiding this comment.
for my own understanding, could you point me to where Lock/Unlock/FlushAppConn were added?
| @@ -19,7 +19,8 @@ func IsClobOrderTransaction( | |||
| return false | |||
| } | |||
|
|
|||
| if len(cosmosTx.Body.Messages) == 1 && | |||
| if cosmosTx.Body != nil && | |||
There was a problem hiding this comment.
nice catch! in what case can the body be empty? is it possible to send an empty body tx?
| replace github.com/cosmos/cosmos-sdk v0.47.0-alpha2 => github.com/dydxprotocol/cosmos-sdk v0.47.0-alpha2-dydx-fork | ||
| replace ( | ||
| github.com/cosmos/cosmos-sdk v0.47.0-alpha2 => github.com/dydxprotocol/cosmos-sdk v0.47.0-alpha2-dydx-fork | ||
| github.com/tendermint/tm-db => github.com/tendermint/tm-db v0.6.6 |
There was a problem hiding this comment.
Above, there's github.com/tendermint/tm-db v0.6.7 which makes me believe that CometBFT intends to use v0.6.7. However, we are overriding that to a prev version here. Why is this the case?
There was a problem hiding this comment.
This question is answered in the PR description
ttl33
approved these changes
Feb 2, 2023
lcwik
pushed a commit
that referenced
this pull request
Apr 26, 2023
* Test commit * empty commit to trigger build * empty commit to trigger build * Fix TestEndBlockValidatorUpdatesResultingInEmptySet * Fix test failures * Add replace using tm-db v0.6.6 * Remove test comment
lcwik
pushed a commit
that referenced
this pull request
Apr 27, 2023
* Test commit * empty commit to trigger build * empty commit to trigger build * Fix TestEndBlockValidatorUpdatesResultingInEmptySet * Fix test failures * Add replace using tm-db v0.6.6 * Remove test comment
roy-dydx
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Test commit * empty commit to trigger build * empty commit to trigger build * Fix TestEndBlockValidatorUpdatesResultingInEmptySet * Fix test failures * Add replace using tm-db v0.6.6 * Remove test comment
roy-dydx
pushed a commit
that referenced
this pull request
Jul 2, 2023
* Test commit * empty commit to trigger build * empty commit to trigger build * Fix TestEndBlockValidatorUpdatesResultingInEmptySet * Fix test failures * Add replace using tm-db v0.6.6 * Remove test comment
roy-dydx
pushed a commit
that referenced
this pull request
Jul 2, 2023
* Test commit * empty commit to trigger build * empty commit to trigger build * Fix TestEndBlockValidatorUpdatesResultingInEmptySet * Fix test failures * Add replace using tm-db v0.6.6 * Remove test comment
roy-dydx
pushed a commit
that referenced
this pull request
Jul 2, 2023
* Test commit * empty commit to trigger build * empty commit to trigger build * Fix TestEndBlockValidatorUpdatesResultingInEmptySet * Fix test failures * Add replace using tm-db v0.6.6 * Remove test comment
roy-dydx
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Test commit * empty commit to trigger build * empty commit to trigger build * Fix TestEndBlockValidatorUpdatesResultingInEmptySet * Fix test failures * Add replace using tm-db v0.6.6 * Remove test comment
roy-dydx
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Test commit * empty commit to trigger build * empty commit to trigger build * Fix TestEndBlockValidatorUpdatesResultingInEmptySet * Fix test failures * Add replace using tm-db v0.6.6 * Remove test comment
lcwik
added a commit
that referenced
this pull request
Aug 30, 2023
lcwik
added a commit
that referenced
this pull request
Aug 30, 2023
lcwik
added a commit
that referenced
this pull request
Aug 30, 2023
matthewdowney
pushed a commit
to matthewdowney/cometbft
that referenced
this pull request
Aug 31, 2023
* Test commit * empty commit to trigger build * empty commit to trigger build * Fix TestEndBlockValidatorUpdatesResultingInEmptySet * Fix test failures * Add replace using tm-db v0.6.6 * Remove test comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unit and end-to-end tests broken by our Tendermint/CometBFT fork.
TestEndBlockValidatorUpdatesResultingInEmptySetto account for the new mempool calls added inApplyBlock.cosmosTx.Bodywasnil.cosmos-sdkin this repository in this commit modified a lot of dependencies due to the way that Go dependency resolution works (as Tendermint and CosmosSDK share a number of dependencies and Go uses MVS). This was breaking some end-to-end tests due to a change intm-dbfrom fromv0.6.6tov0.6.7. Specificallytm-dbincludesrocksdbas a dependency andv0.6.7seems to changerocksdbfromtecbot/gorocksdbtocosmos/gorocksdbwhich seems to be a breaking change, incompatible with the wayrocksdbis being installed in the end-to-end tests in this repository. As a solution here I added a replacement direction to usetm-dbatv0.6.6, which is the version used upstream.KeepInvalidTxsInCachetofalseinDefaultMempoolConfig, which was causing unit tests to fail. This value should was modified in this commit, but instead should be modified in the configuration, so I did that here inv4instead.