[CLOB-547] IsClobOrderTransaction only filter out Short-Term orders/cancels.
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakob-dydx
approved these changes
May 16, 2023
| @@ -1,6 +1,8 @@ | |||
| version: v1 | |||
| deps: | |||
| - buf.build/cosmos/gogo-proto | |||
| # Latest release was in Dec 2021, https://buf.build/cosmos/cosmos-proto/commits/main | |||
| - buf.build/cosmos/cosmos-proto:1935555c206d4afb9e94615dfd0fad31 | |||
There was a problem hiding this comment.
Can we add some documentation to the README.md of this project around the following:
- The fact that we are copy/pasting protos into this repo, and that they should stay in sync with
dydxprotocol/v4for now (until we find a better solution). - The steps to follow to update them, compile them, and the steps to update the `buf.yaml file.
prettymuchbryce
approved these changes
May 16, 2023
roy-dydx
pushed a commit
that referenced
this pull request
Jun 30, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Jul 2, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Jul 2, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Jul 2, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Jul 3, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Jul 11, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 30, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 30, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 30, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 30, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 30, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 30, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 30, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 30, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 31, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 31, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 31, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 31, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 31, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Aug 31, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
matthewdowney
pushed a commit
to matthewdowney/cometbft
that referenced
this pull request
Aug 31, 2023
…/cancels. (dydxprotocol#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Dec 4, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Dec 4, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
lcwik
added a commit
that referenced
this pull request
Dec 4, 2023
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Feb 20, 2024
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Apr 9, 2024
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Apr 9, 2024
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Apr 14, 2024
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Apr 16, 2024
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Apr 16, 2024
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Apr 16, 2024
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
roy-dydx
pushed a commit
that referenced
this pull request
Apr 22, 2024
…/cancels. (#7) * generate protos for dydx * add the matches and tx protos * add dydx order id logic and constants * IsClobOrderTransaction => IsShortTermClobOrderTransaction * disable lint for dydx order id constants * more specific linter disables * rename proto package due to global proto registry name clash * Update import paths for dydx clob types * helpful text string function for order id * minor pr comments, no logic changes * README updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosen restrictions on
IsClobOrderTransactionto allow Stateful orders/cancels through into block proposal. Short term orders/cancels will still be filtered out.Uses some dydx protos that had to be ported over into this repo.