Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump dydx sdk fork #2

Closed
wants to merge 112 commits into from

Conversation

faddat
Copy link

@faddat faddat commented Jan 3, 2023

Description

Nice committer!

If using the v0.46.0-fork branch, you've got a bit of a bank module bug currently, which was corrected upstream. This PR will correct that.

Do you plan to build on 46 or 47?


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

mergify bot and others added 30 commits July 27, 2022 16:46
… balance for a given denom (backport cosmos#12674) (cosmos#12744)

* feat: Add convenience method for constructing key to access account's balance for a given denom (cosmos#12674)

This PR adds a convenience method for constructing the key necessary to query for the account's balance of a given denom.

I ran into this issue since we are using ABCI query now to perform balance requests because we are also requesting merkle proofs for the returned balance [here](https://github.com/celestiaorg/celestia-node/pull/911/files#diff-0ee31f5a7bd88e9f758e6bebdf3ee36365519e55a451098d9638c39afe5eac42R144).

It would be nice to have a definitive convenience method for constructing the key.

[Ref.](github.com/celestiaorg/celestia-node/pull/911)

(cherry picked from commit a1777a8)

* updates changelog

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
…ges (backport cosmos#12615) (cosmos#12792)

* feat: Add GetParamSetIfExists to prevent panic on breaking param changes (cosmos#12615)

* imp(params): Add GetParamSetIfExists to prevent panic on breaking param changes

* changelog

* test

Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 2932e11)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit fe89212)

Co-authored-by: Ari Rubinstein <arirubinstein@users.noreply.github.com>
…osmos#12840)

(cherry picked from commit cfed17e)

Co-authored-by: lg <8335464+glnro@users.noreply.github.com>
* chore: bump math package

* changelog
…osmos#12888) (cosmos#12890)

* fix(x/group): propagate events correctly to current context (cosmos#12888)

* fix(x/groups) propagate events correctly to current context

* update to use current context on logger

* adding changelog entry

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
(cherry picked from commit 014bfae)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>
* chore: bump tendermint to `0.34.21` and iavl to `0.19.1`

* update changelog
* docs(cli): improve --gas flag description

* Update client/flags/flags.go

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* fix sprintf

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit f430528)

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
…os#12981) (cosmos#12998)

* fix: proper error when parsing telemetry configuration (cosmos#12981)

When parsing `telemetry.global-labels` config the code assumes that the type will be an array.  I saw an issue where someone edited the configuration in the wrong way and got the following error:
![photo_2022-08-21_08-02-21](https://user-images.githubusercontent.com/22855163/185793842-c5759a54-1860-4dd1-bdb4-b94f4dab3c16.jpg)
Instead, I suggest here to print a proper error log to indicate what the issue is.

(cherry picked from commit c24c439)

* add changelog

Co-authored-by: liorbond <liorbond@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
…12646) (cosmos#13004)

* docs: improve UPGRADING.md instructions for v0.46.0 (cosmos#12646)

## Description

This PR is aimed to improve further the UGPRADING.md for v0.46.0.
We've merged cosmos#12477 for having concurrent work on the file.

- ref cosmos#12992 and closes cosmos#12991
- closes cosmos#12963

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit c76a00b)

# Conflicts:
#	.gitignore
#	CHANGELOG.md
#	Makefile
#	UPGRADING.md

* fix conflict

Co-authored-by: Julien Robert <julien@rbrt.fr>
…(backport cosmos#12953) (cosmos#13006)

* feat: Change the default priority mechanism to be based on gas price (cosmos#12953)

(cherry picked from commit befd816)

# Conflicts:
#	CHANGELOG.md
#	x/auth/ante/fee_test.go

* fix conflict

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
* chore: v0.46.1 release changelog

* updates

* updates
) (cosmos#13018)

* ci: fix release notes not populated by goreleaser

(cherry picked from commit c670fec)

# Conflicts:
#	cosmovisor/go.mod
#	cosmovisor/go.sum
#	go.work.sum

* updates

* revert

Co-authored-by: Julien Robert <julien@rbrt.fr>
…smos#13037)

* fix: exporting the blockParams regression (cosmos#13029)

## Description

Closes: cosmos#13024

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit e1999e4)

# Conflicts:
#	CHANGELOG.md
#	server/export_test.go

* fix conflicts

Co-authored-by: JayT106 <JayT106@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
cosmos#13049)

* fix: missing return statement in BaseApp.Query (cosmos#13046)

## Description

Closes: cosmos#13040

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit c73171f)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: Julien Robert <julien@rbrt.fr>
) (cosmos#13052)

* feat(x/authz): Add the GetAuthorization function. (cosmos#13047)

* [13027]: Create the GetAuthorization function (in the authz module).

* [13027]: Add unit tests for the new GetAuthorization function.

* [13027]: Add changelog entry.

(cherry picked from commit 5e4651e)

# Conflicts:
#	CHANGELOG.md
#	x/authz/keeper/keeper_test.go

* fix changelog

* Fix failed merge.

* Fix build issue introduced by merge.

Co-authored-by: Daniel Wedul <github@wedul.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
* deps: bump gin-gonic (cosmos#13061)

Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit d11196a)

# Conflicts:
#	go.sum

* fix conflicts

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
…kport cosmos#13107) (cosmos#13108)

* fix: call `SetIAVLCacheSize` with the configured value in simapp (cosmos#13107)

* Call `SetIAVLCacheSize` with the configured value in simapp.

* Update CHANGELOG.md

(cherry picked from commit ab33342)

# Conflicts:
#	CHANGELOG.md

* Apply suggestions from code review

Co-authored-by: yihuang <huang@crypto.com>
…port cosmos#11361) (cosmos#13089)

* fix: rollback command don't actually delete multistore versions (cosmos#11361)

* rollback command don't actually delete multistore versions

Closes: cosmos#11333

- add unit tests
- use LoadVersionForOverwriting
- update tendermint dependency to 0.35.x release branch

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

flushMetadata after rollback

Update server/rollback.go

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

fix build

gofumpt

* fix unit test

(cherry picked from commit 51d2de5)

* fix unit test

* changelog

* api breaking changelog

Co-authored-by: yihuang <huang@crypto.com>
… (backport cosmos#12742) (cosmos#13119)

* feat: Add a cli cmd to prune old states according to current settings (cosmos#12742)

* add PruningCmd and change PruneStores signature

* the mimimum default pruning interval is 10

Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit d874ace)

* fix backport error

Co-authored-by: adu-crypto <94821467+adu-crypto@users.noreply.github.com>
Co-authored-by: adu <adu.du@crypto.com>
cosmos#13136)

* chore: replace deprecated dgrijalva/jwt-go dep (cosmos#13093)

* chore: replace deprecated dgrijalva/jwt-go dep

* Update go.mod

(cherry picked from commit f5f84ad)

# Conflicts:
#	go.mod
#	go.sum

* fix conflict

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat changed the title Bump dydx sdk fork chore: Bump dydx sdk fork Jan 3, 2023
@prettymuchbryce
Copy link

Hey @faddat. Thanks for letting us know. We've since updated to 0.47.X, so presumably the fix has already been merged upstream?

@faddat
Copy link
Author

faddat commented Jan 31, 2023

Yes that means that you are all good. I'd love to hear any feedback that you have on using 47 and have a wonderful day!

lcwik added a commit that referenced this pull request Sep 8, 2023
…e vulnerability

Context: https://github.com/dydxprotocol/cosmos-sdk/actions/runs/6126061229/job/16629299626?pr=26

Details:

Scanning your code and 822 packages across 139 dependent modules for known vulnerabilities...
Vulnerability #1: GO-2023-2043
    Improper handling of special tags within script contexts in html/template
  More info: https://pkg.go.dev/vuln/GO-2023-2043
  Standard library
    Found in: html/template@go1.19.13
    Fixed in: html/template@go1.21.1
    Example traces found:
Error:       #1: server/api/server.go:111:27: api.Server.Start calls server.Serve, which eventually calls template.Template.Execute
Error:       #2: server/api/server.go:111:27: api.Server.Start calls server.Serve, which eventually calls template.Template.ExecuteTemplate
Vulnerability #2: GO-2023-2041
    Improper handling of HTML-like comments in script contexts in html/template
  More info: https://pkg.go.dev/vuln/GO-2023-2041
  Standard library
    Found in: html/template@go1.19.13
    Fixed in: html/template@go1.21.1
    Example traces found:
Error:       #1: server/api/server.go:111:27: api.Server.Start calls server.Serve, which eventually calls template.Template.Execute
Error:       #2: server/api/server.go:111:27: api.Server.Start calls server.Serve, which eventually calls template.Template.ExecuteTemplate
=== Informational ===
Found 2 vulnerabilities in packages that you import, but there are no call
stacks leading to the use of these vulnerabilities. You may not need to
take any action. See https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck
for details.
Vulnerability #1: GO-2023-2045
    Memory exhaustion in QUIC connection handling in crypto/tls
  More info: https://pkg.go.dev/vuln/GO-2023-2045
  Standard library
    Found in: crypto/tls@go1.19.13
    Fixed in: crypto/tls@go1.21.1
Vulnerability #2: GO-2023-2044
    Panic when processing post-handshake message on QUIC connections in
    crypto/tls
  More info: https://pkg.go.dev/vuln/GO-2023-2044
  Standard library
    Found in: crypto/tls@go1.19.13
    Fixed in: crypto/tls@go1.21.1
Your code is affected by 2 vulnerabilities from the Go standard library.
Share feedback at https://go.dev/s/govulncheck-feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment