Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTE-150] Add a pessimistic store and allow for its use by updating interfaces and multistore implementation to support branching and locking. #43

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

lcwik
Copy link

@lcwik lcwik commented Feb 26, 2024

Description

[OTE-150] Add a pessimistic store and allow for its use by updating interfaces and multistore implementation to support branching and locking.

Added tests.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link

linear bot commented Feb 26, 2024

Copy link

@lcwik your pull request is missing a changelog!

…nterfaces and multistore implementation to support branching and locking.
@@ -199,3 +199,5 @@ retract (
)

replace github.com/cometbft/cometbft => github.com/dydxprotocol/cometbft v0.38.6-0.20240220185844-e704122c8540

replace cosmossdk.io/store => github.com/dydxprotocol/cosmos-sdk/store v1.0.3-0.20240226230141-2bbd3559a170

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be annoying to maintain; I assume we can't self reference here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is annoying, not sure how to do it otherwise.

Only would need to update the store reference if you change files under store/ so it should be relatively limited.

@lcwik lcwik merged commit f4e166b into dydx-fork-v0.50.4 Feb 27, 2024
37 of 40 checks passed
@lcwik lcwik deleted the lukesig branch February 27, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants