[OTE-567] chore: Fix broken CI, enable workflow on dydx-fork branches
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyding
force-pushed
the
td/fix-ci
branch
3 times, most recently
from
5795356
to
0224b6b
Compare
teddyding
commented
Jul 17, 2024
| @@ -1,23 +0,0 @@ | |||
| # Staticmajor: Static analyzer to catch leaking resources & other bad code patterns | |||
There was a problem hiding this comment.
This file is also removed from cosmos-sdk main due to false postives: cosmos@9e9cc52
teddyding
changed the title
dydx-fork branches
teddyding
changed the title
dydx-fork branchesdydx-fork branches
teddyding
commented
Jul 17, 2024
| @@ -27,7 +27,7 @@ require ( | |||
| github.com/cosmos/gogoproto v1.4.11 | |||
| github.com/cosmos/ledger-cosmos-go v0.13.3 | |||
| github.com/decred/dcrd/dcrec/secp256k1/v4 v4.2.0 | |||
| github.com/ethereum/go-ethereum v1.12.0 | |||
| github.com/ethereum/go-ethereum v1.13.15 | |||
There was a problem hiding this comment.
Upgraded versions according to output of dependency-review workflow
teddyding
changed the title
dydx-fork branchesdydx-fork branches
teddyding
commented
Jul 17, 2024
| }) | ||
| } | ||
| } | ||
| // CancelProposal is not supported in dYdX chain. Leaving this test case commented out. |
There was a problem hiding this comment.
This was failing e2e test workflow. Didn't want to spend a long time troubleshooting considering this message is disabled in v4-chain. Commenting out instead of deleting, in case we want to use MsgCancelProposal in the future.
BrendanChou
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken CI workflows and re-enable them on
dydx-fork-*branch