Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a number of issues with orderbook display. #299

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Fix a number of issues with orderbook display. #299

merged 3 commits into from
Nov 18, 2024

Conversation

ruixhuang
Copy link
Contributor


Description / Intuition

  • Fix staled color change within orderbook entry.
  • Calculate the orderbook maxDepth as the max of both side.

Before/After Screenshots or Videos

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-18.at.14.01.43.mp4

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@ruixhuang ruixhuang marked this pull request as ready for review November 18, 2024 22:06
@ruixhuang ruixhuang merged commit c7aac0d into develop Nov 18, 2024
4 checks passed
@ruixhuang ruixhuang deleted the feature/orderbook_layout branch November 18, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyleroooo tyleroooo tyleroooo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruixhuang @tyleroooo