Use Deno.FsFile.syncDataSync

It will be stabilized in Deno v1.44
dyedgreen · May 8, 2024 · 781bd0a · 781bd0a
1 parent c6ee87e
commit 781bd0a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -32,6 +32,8 @@ jobs:
     - name: Run tests (unstable)
       run: /home/runner/.deno/bin/deno test --unstable --allow-read --allow-write
     - name: Run tests (DENO_FUTURE)
+      run: DENO_FUTURE=1 /home/runner/.deno/bin/deno test --allow-read --allow-write
+    - name: Run tests (DENO_FUTURE and unstable)
       run: DENO_FUTURE=1 /home/runner/.deno/bin/deno test --unstable --allow-read --allow-write
     - name: Run benchmarks
       run: /home/runner/.deno/bin/deno run bench.ts
diff --git a/build/vfs.js b/build/vfs.js
@@ -87,13 +87,7 @@ export default function env(inst) {
     // Sync file data to disk
     js_sync: (rid) => {
       const file = getOpenFile(rid);
-      if (typeof file.rid === "number") {
-        // Uses deprecated Deno.FsFile.rid, which will be removed in Deno 2.0
-        Deno.fdatasyncSync(file.rid);
-      } else {
-        // Support DENO_FUTURE, but requires --unstable-fs
-        file.syncDataSync();
-      }
+      file.syncDataSync();
     },
     // Retrieve the size of the given file
     js_size: (rid) => {