Update Browser Build for Deno 2 #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry for taking a while to get back to this! This change looks great, outside of a few files that are flagged by the formatting in CI 👀 (Some of those have not changed in a while so they might have changed the formatting in Deno?) |
dyedgreen
reviewed
Nov 21, 2024
| @@ -85,7 +85,7 @@ There is **experimental** support for using `deno-sqlite` in the browser. You | |||
| can generate a browser compatible module by running: | |||
|
|
|||
| ```bash | |||
| deno bundle --import-map browser/import_map.json browser/mod.ts [output_bundle_path] | |||
| deno run --allow-run --allow-env --allow-read --allow-write ./browser/bundle.js | |||
There was a problem hiding this comment.
I think we can look down permissions a bit more here?
--allow-run isn’t required, and we can scope reading to the repo and writing to just the bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
deno bundle(now deprecated)vfs.js, which supports the browser build, to be in line with the local builddeno.jsonto handle import maps (standard in Deno 2) for the browser buildREADME.mdin line with the above changesNotes for Reviewers
vfs.jsarise from runningdeno fmtagainst the file