Dispatch improvements #1620
Merged
Dispatch improvements #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods on subclasses of <wrapper-stream> often make heavy use of inner-stream, which is an open generic function. To ensure that calls to inner-stream are dispatched efficiently, this change adds sealing definitions for inner-stream on <wrapper-stream> subclasses. * sources/io/streams/wrapper-stream.dylan (inner-stream on <wrapper-stream>): Make method inline due to its simplicity and performance benefit. * sources/io/streams/indenting-streams.dylan: Seal inner-stream on <indenting-stream>. * sources/lib/coloring-stream/coloring-stream.dylan: Seal inner-stream on <coloring-stream>. * sources/lib/progress-stream/progress-stream.dylan: Seal inner-stream on <progress-stream>. * sources/lib/llvm/bitcode.dylan: Seal inner-stream on <bitcode-stream>.
* sources/lib/llvm/llvm-bitcode.dylan (write-module): Declare the proper type of llvm-module-functions elements. * sources/lib/llvm/bitcode.dylan (stream-record-id): Add type declarations for bitcode-records elements. (write-abbrev-record): Add type declarations for bitcode-abbrev-definitions entries and abbrev-ops elements.
cgay
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes improve wrapper stream performance, including for LLVM bitcode steams, and make other method dispatch improvements in LLVM bitcode output.