LocalIP (macOS): improve detection #2362
Conversation
When a VPN session is enabled, the default route interface is changed to `utun*`, however `ipconfig` doesn't support it for some reason Use `ifconfig` instead
|
Ad: Use fastfetch for more powerful and faster Local IP detection
|
|
@hykilpikonna 你为什么可以在别人的仓库里批准PR？ |
This is a standard feature on Github, anyone can approve PR in any public repository. Sorry for the delay, I'll merge this to HyFetch after I test it on my macOS system later. |
How? |
|
|
Found one issue: If the reverse DNS lookup for the gateway takes too long, the
|
|
IP local address works!
|
…e detection Upstream PR: dylanaraps/neofetch#2362 Thanks to @CarterLi Co-authored-by: 李通洲 <zhangsongcui3371@sina.com>
|
Thank you for your contribution! This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained. HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo. Read the "Running Updated Original Neofetch" section for more info! |
|
Please don't do that. I'm submitting this PR is for advertising my work. I don't care if it gets merged or not
|
I apologize for assuming that everyone who opens a pull request wants to contribute to the project, and it's unfortunate that you don't care whether your contribution is accepted. I'm grateful for your contribution regardless. 😃 |
When a VPN session is enabled, the default route interface is changed to
utun*, howeveripconfigdoesn't support it for some reasonUse
ifconfiginstead