-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(streamer): added streamer pagination #1100
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
f99c175
to
c1f91a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work. left some comments
1fcc4e7
to
81e138c
Compare
@keruch build fails |
25caeb2
to
a1e983b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1100 +/- ##
==========================================
- Coverage 28.22% 25.37% -2.86%
==========================================
Files 332 502 +170
Lines 52494 99084 +46590
==========================================
+ Hits 14818 25139 +10321
- Misses 35346 70713 +35367
- Partials 2330 3232 +902 ☔ View full report in Codecov by Sentry. |
Description
Added streamer pagination. ADR: https://www.notion.so/dymension/ADR-x-Streamer-Pagination-ad21ef72458e472cad9fb6f9932c16cd.
BeforeEpochStart
hookAfterEpochEnd
hookEndBlock
Please pay special attention to
Closes #1010
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
<- only in one place and under my supervisiontime.Now()
sendCoin
and notSendCoins
Full security checklist here
For Reviewer:
After reviewer approval: