Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollapp): delete stale state updates #1176

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

zale144
Copy link
Contributor

@zale144 zale144 commented Sep 2, 2024

Description


Closes #938

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@zale144 zale144 self-assigned this Sep 2, 2024
@zale144 zale144 marked this pull request as ready for review September 3, 2024 12:10
@zale144 zale144 requested a review from a team as a code owner September 3, 2024 12:10
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions but principle is good

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
x/rollapp/keeper/state_info.go Outdated Show resolved Hide resolved
x/rollapp/keeper/state_info.go Outdated Show resolved Hide resolved
x/rollapp/keeper/state_info.go Outdated Show resolved Hide resolved
x/rollapp/keeper/hooks.go Outdated Show resolved Hide resolved
x/rollapp/keeper/hooks.go Outdated Show resolved Hide resolved
x/rollapp/keeper/hooks.go Outdated Show resolved Hide resolved
danwt
danwt previously approved these changes Sep 9, 2024
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

mtsitrin
mtsitrin previously approved these changes Sep 10, 2024
proto/dymensionxyz/dymension/rollapp/params.proto Outdated Show resolved Hide resolved
x/rollapp/keeper/hooks.go Outdated Show resolved Hide resolved
x/rollapp/keeper/state_info.go Show resolved Hide resolved
x/rollapp/types/key_state_info.go Show resolved Hide resolved
@zale144 zale144 dismissed stale reviews from mtsitrin and danwt via 3e0037b September 12, 2024 09:12
@mtsitrin mtsitrin merged commit 0f876b3 into main Sep 12, 2024
64 of 128 checks passed
@mtsitrin mtsitrin deleted the zale144/938-delete-stale-state-updates branch September 12, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete non used state updates - Impl
3 participants