Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Release Binary #576

Merged
merged 2 commits into from
Feb 29, 2024
Merged

CI: Release Binary #576

merged 2 commits into from
Feb 29, 2024

Conversation

anhductn2001
Copy link
Contributor

Description


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpeted math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@anhductn2001 anhductn2001 requested a review from a team as a code owner February 19, 2024 06:27
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd821aa) 30.71% compared to head (bfd8fcf) 30.71%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   30.71%   30.71%           
=======================================
  Files         166      166           
  Lines       25719    25719           
=======================================
  Hits         7900     7900           
  Misses      16552    16552           
  Partials     1267     1267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

- name: Docker compose
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anhductn2001 why u need to run the application before binary release? kind of validation?

Copy link
Contributor Author

@anhductn2001 anhductn2001 Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's the simplest approach we can think of at the moment, and it also helps us to verify whether a node can run with the current binary on the Docker environment. Later on, I'll consider expanding it with goreleaser for further development.

@omritoptix omritoptix merged commit 0246f11 into dymensionxyz:main Feb 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants