Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores(deps): bump dependencies cosmos-sdk v0.47.13 #970

Merged
merged 36 commits into from
Jul 17, 2024

Conversation

spoo-bar
Copy link
Contributor

@spoo-bar spoo-bar commented Jun 27, 2024

Description

Version bumps to the following:

  • cosmos-sdk v0.47.13
  • ibc-go v7.5.1
  • cometbft v0.37.5
  • packet forward middleware v7.1.3

Changes:

  • Replacing tendermint with cometbft
  • Replacing tendermint-db with cometbft-db
  • Updating the coker image used for proto generation
  • Using the sdk provided genesis funcs
  • Passing in governance module as authority address for the sdk modules
  • Posthandler wiring
  • Register autocli
  • Add upgrade handler for v4
  • Refactored streamer tests which was using osmosis-fork testing framework to use the dymension's testing framework
  • Reorganizing the proto files to match their proto paths (this is required by cosmos sdk)
  • Removing Route, QuerierRoute and LegacyQuerierHandler from modules as they are deprecated

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@spoo-bar spoo-bar marked this pull request as ready for review June 27, 2024 13:23
@spoo-bar spoo-bar requested a review from a team as a code owner June 27, 2024 13:23
@VictorTrustyDev
Copy link
Contributor

Hey @spoo-bar
When I do make proto-gen on this branch, I got gogo/protobuf in pb files.
How did you generated those files?

Screen Shot 2024-06-28 at 18 41 24

@spoo-bar
Copy link
Contributor Author

Hey @spoo-bar When I do make proto-gen on this branch, I got gogo/protobuf in pb files. How did you generated those files?

Screen Shot 2024-06-28 at 18 41 24

Pushed the buf.gen.gogo.yaml changes which should fix it.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 48.79808% with 213 lines in your changes missing coverage. Please review.

Project coverage is 28.52%. Comparing base (2528e5d) to head (8e82312).
Report is 1 commits behind head on main.

Files Patch % Lines
app/upgrades/v4/upgrade.go 2.12% 45 Missing and 1 partial ⚠️
x/rollapp/types/query.pb.go 13.33% 13 Missing ⚠️
app/app.go 92.70% 5 Missing and 5 partials ⚠️
x/sequencer/types/query.pb.go 16.66% 10 Missing ⚠️
x/streamer/types/query.pb.go 16.66% 10 Missing ⚠️
x/eibc/types/query.pb.go 22.22% 7 Missing ⚠️
testutil/network/network.go 0.00% 6 Missing ⚠️
x/sequencer/types/tx.pb.go 33.33% 6 Missing ⚠️
...enommetadata/client/cli/tx_create_denommetadata.go 0.00% 5 Missing ⚠️
...enommetadata/client/cli/tx_update_denommetadata.go 0.00% 5 Missing ⚠️
... and 40 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
+ Coverage   28.35%   28.52%   +0.17%     
==========================================
  Files         253      253              
  Lines       33675    33853     +178     
==========================================
+ Hits         9547     9658     +111     
- Misses      22775    22834      +59     
- Partials     1353     1361       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zale144 zale144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! just left a couple of comments to sort out

go.mod Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
cmd/dymd/cmd/inspect_tendermint.go Show resolved Hide resolved
@spoo-bar spoo-bar requested a review from zale144 July 3, 2024 10:18
app/upgrades/v4/upgrade.go Outdated Show resolved Hide resolved
app/upgrades/v4/upgrade.go Outdated Show resolved Hide resolved
app/upgrades/v4/upgrade.go Outdated Show resolved Hide resolved
@spoo-bar spoo-bar requested a review from zale144 July 9, 2024 10:51
cmd/dymd/cmd/root.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
@spoo-bar spoo-bar changed the title chores(deps): bump dependencies cosmos-sdk v0.47.12 chores(deps): bump dependencies cosmos-sdk v0.47.13 Jul 15, 2024
@omritoptix omritoptix merged commit 31156de into dymensionxyz:main Jul 17, 2024
9 of 96 checks passed
@spoo-bar spoo-bar deleted the spoorthi/upgrade-sdk-to-v.47 branch July 17, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants