Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multidb migrations #243

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

multidb migrations #243

wants to merge 14 commits into from

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Dec 10, 2024 •
edited
Loading

Changes

  • add improved multidb support for migrations
  • split test settings
  • add multi db tests
  • add templates
  • bump version

This PR is ready for testing. If everything went well we can release soon

@devkral
WIP: multidb migrations
e37c738 
Changes

- add real multidb support for migrations
- split test settings
- add multi db tests
@devkral devkral marked this pull request as draft December 10, 2024 17:13
@devkral
add flask-migrate compatibility
aafe92b
@devkral
Changes:
1f6bbb9 
- only migrate dbs in migrate_databases
@devkral
Changes:
9d264d6 
- update docs
- fix bug in case more dbs are slated for migrations
@devkral
Changes:
e29e29e 
- add templates
- splitout hashing
- more tests
@devkral
fix typings for older python
b8dd72d
@devkral
Changes:
51b0437 
- fix tests
- fix bug when doing automigrations
@devkral devkral changed the title WIP: multidb migrations multidb migrations Dec 11, 2024
@devkral devkral marked this pull request as ready for review December 11, 2024 23:36
@devkral
Changes:
e56baa9 
- document more changes
- improve error and strictness
tarsil
tarsil reviewed Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@tarsil tarsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to make the change now but before we release, just make sure the capitals are in the right place

docs/migrations/migrations.md Outdated Show resolved Hide resolved
tarsil
tarsil previously approved these changes Dec 12, 2024
View reviewed changes
@devkral
Changes:
2750b19 
- extended migration tests
- update release notes
- fixes
- allow passing database as attribute (required for tests)
- allow passing a different registry for preparation
@devkral
Changes:
2e506a1 
- fix url template, should only use netloc and username
- allow bytes for identifier hasher
@devkral devkral force-pushed the devkral/feature/multidb_migrate branch from 877a184 to 2e506a1 Compare December 14, 2024 07:18
@devkral
fix typo
d999381
@devkral
Changes:
40f6758 
- fix error on create
@devkral
Changes:
526869f 
- extra names are checked
- allow selecting the main database via space
- documentation update
@devkral
changes:
8661c64 
fix typo
@devkral
Copy link
Contributor Author

devkral commented Dec 15, 2024 •
edited
Loading

I think the PR is ready for merging when the docs are ok.

I updated the tests, so I am quite sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarsil tarsil tarsil left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devkral @tarsil