PCLOUDS-2709 Implemented enabling User assigned managed Identity #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deployment/dynatrace-azure-logs.sh
Outdated
| @@ -61,6 +61,15 @@ arguments: | |||
| Optional. Apply filters to reduce number of logs that are sent to Dynatrace e.g. filter out logs with Informational level. | |||
| --repository-release-url REPOSITORY_RELEASE_URL | |||
| Change repository url to custom. Do not change without specific reason | |||
| --enable-using-user-assigned-managed-identity {true|false} | |||
There was a problem hiding this comment.
so long - what about use-user-assigned-managed-identity or user-assign-managed-identity ?
| The client id of User-Assigned MI | ||
| --managed-identity-resource-name MANAGED_IDENTITY_RESOURCE_NAME | ||
| Name of the Managed Identity resource | ||
| --eventhub-connection-fully-qualified-namespace EVENT_HUB_CONNECTION_FULLY_QUALIFIED_NAMESPACE |
There was a problem hiding this comment.
What about eventhub-namespace ?
deployment/dynatrace-azure-logs.sh
Outdated
| @@ -61,6 +61,15 @@ arguments: | |||
| Optional. Apply filters to reduce number of logs that are sent to Dynatrace e.g. filter out logs with Informational level. | |||
| --repository-release-url REPOSITORY_RELEASE_URL | |||
| Change repository url to custom. Do not change without specific reason | |||
| --enable-user-assigned-managed-identity {true|false} | |||
| Optional, 'false' by default | |||
| if you choose to use user-assigned-managed-identity, you need to change it to 'true' and provide EVENT_HUB_CONNECTION_CLIENT_ID and EVENT_HUB_CONNECTION_FULLY_QUALIFIED_NAMESPACE | |||
There was a problem hiding this comment.
Not also MANAGED_IDENTITY_RESOURCE_NAME?
|
Kudos, SonarCloud Quality Gate passed!
|
joaquinfilipic-dynatrace
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.