Modest extras/gtomb update
#477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About Update "1"
Some messages like
Success: Tour tomb has been dug in ...was appearing BEFORE the tomb was actually dug. With awaitstatement the message appears AFTER the tomb has been created. Similar situations occurred in forge, lock and open functions.About Update "2"
My previous PR #465 (merged) used soft tabs, because my editor uses soft tabs, but gtomb itself uses hard tabs. Now uniform.
About Update "3"
Most of text is in english British, Canadian, Australian (cancelled) but a few times "cancelled" appears spelled as "canceled" (USA english).
About Update "4"
Just a simplification. All warning messages but one, have title "Warning", that one had title "gtomb". I have moved title to inside the function.
About Update "5"
Self explanatory.