Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated manpage and help file #481

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Updated manpage and help file #481

merged 2 commits into from
Jun 27, 2023

Conversation

nerun
Copy link
Contributor

@nerun nerun commented Jun 26, 2023

I just run:

man -Tpdf ./tomb.1 > tomb_manpage.pdf

In the other commit i have updated help messages:

From this:

passwd       change the password of a KEY (needs old pass)
setkey       change the KEY locking a TOMB (needs old key and pass)

// Backup on paper:
engrave makes a QR code of a KEY to be saved on paper

To this:

passwd       change the password of a KEY (needs old pass)
setkey       change the KEY locking a TOMB (needs old key and pass)

// Backup on paper:
engrave      makes a QR code of a KEY to be saved on paper

@nerun nerun changed the title doc/tomb_manpage.pdf updated with new version. Updated manpage and help file Jun 26, 2023
@@ -786,7 +786,7 @@ usage() {
echo
[[ $QRENCODE == 1 ]] && {
_print " // Backup on paper:"
_print " engrave makes a QR code of a KEY to be saved on paper"
_print " engrave makes a QR code of a KEY to be saved on paper"
Copy link
Collaborator

@Narrat Narrat Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that this is an intended change?
Or generally asked: Why is the spacing needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this is the right way, because all the text has this tabulation. As you can see here when i execute --help:

Captura de tela de 2023-06-26 17-04-41

it's in Brazilian Portuguese because i am working on this translation. But you can see the engrave is lined up in my translation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Missed that, because I don't have that dep installed and didn't notice it was the help text.
Just saw the diff and not the surroundings :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or generally asked: Why is the spacing needed?

Ok, is not NEEDED, it's just aesthetics.

Copy link
Member

@jaromil jaromil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR reminds me that at some point we should generate the PDF file via github actions rather than committing a binary into this repo. But OK for now.

@jaromil jaromil merged commit 7249afe into dyne:master Jun 27, 2023
2 checks passed
@nerun nerun deleted the doc branch June 27, 2023 12:10
nerun added a commit to nerun/Tomb that referenced this pull request Jun 27, 2023
(2) Created a README file to clear up some confused issues about versioning;
(3) Updated 'es', 'fr', 'it' and 'ru.po' to line up help message (PR dyne#481 and
Jaromil request in PR dyne#483);
(4) Added Brazilian Portuguese translation (for Tomb 2.3 and 2.10);
(5) Created new tomb.pot template based upon Tomb 2.10 (current);
nerun added a commit to nerun/Tomb that referenced this pull request Jun 27, 2023
@nerun nerun mentioned this pull request Jun 27, 2023
jaromil pushed a commit that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants