Fix for crashing on relocating at unistrumentable points #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is to address issue dyninst#455. When an unistrimentable point is selected for instrimenation the behaviour Dyninst will now exhibit is the following: 1. InsertSnippet will return NULL if not in an insertion set and an illegal when parameter is used 2. If in an insertion set, InsertSnippet will return an object to the instrimentation. However when the set is closed the insertion of that point will fail. It will either fail and continue to the next point (if the insertion set closure is set to continue past errors) or roll back all prior insertions. .
|
Build triggered. sha1 is merged. |
|
Build started sha1 is merged. |
|
Build finished. 0 tests run, 0 skipped, 0 failed. |
|
Can be merged as-is. |
|
Do not see build issues with this, mergable as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is to address issue #455. When an unistrimentable point is selected for instrimenation
the behaviour Dyninst will now exhibit is the following:
InsertSnippet will return NULL if not in an insertion set and an illegal when parameter is used
If in an insertion set, InsertSnippet will return an object to the instrimentation. However when the set
is closed the insertion of that point will fail. It will either fail and continue to the next point (if
the insertion set closure is set to continue past errors) or roll back all prior insertions.
.