kpatch-build: remove duplicated use_klp_arch #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two versions are not the same (4.18.0-240.el8 vs. 4.18.0-284.el8). But I am not quite sure which one is accurate. Remove the first one as the second one is being used before this change. Signed-off-by: Song Liu <song@kernel.org>
jpoimboe
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Wow, good catch. It looks like #1163 and #1174 had two different versions of
the same patch. When they were merged, git silently did the wrong thing. Then
I guess shellcheck doesn't detect duplicate functions.
Luckily the 2nd function was correct, which I assume takes precedence since it overrides the first.
|
Yeah, oops. kernel-4.18.0-284.el8 was when we backported the klp.arch removal code, so that is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two versions are not the same (4.18.0-240.el8 vs. 4.18.0-284.el8).
But I am not quite sure which one is accurate. Remove the first one as the
second one is being used before this change.
Signed-off-by: Song Liu song@kernel.org