Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[app] add pdb and rbac, various #271

Merged
merged 6 commits into from
Nov 15, 2023
Merged

[app] add pdb and rbac, various #271

merged 6 commits into from
Nov 15, 2023

Conversation

voron
Copy link
Contributor

@voron voron commented Nov 13, 2023 •
edited
Loading

  • add PDB, some handling of empty and 0 values
  • add Role & RoleBinding
  • add extra selectors for service to allow to match extra labels compared to controller's matchLabels. It's useful to manipulate by these extra labels to include/exclude pods into service without bothering controller's logic
  • style
  • add stringData work-around in Secret, see this helm/k8s issue

@voron voron requested a review from VladStarr November 13, 2023 13:04
VladStarr
VladStarr requested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@VladStarr VladStarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, the only one blocker is PDB

@voron voron requested a review from VladStarr November 15, 2023 11:59
VladStarr
VladStarr approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@VladStarr VladStarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@voron voron merged commit 1f94624 into main Nov 15, 2023
2 checks passed
@voron voron deleted the app-add-pdb-rbac branch November 15, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladStarr VladStarr VladStarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voron @VladStarr