docs: added new locale string and release notes #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying dyte-docs with
|
| Latest commit: |
500f8b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e808046f.dyte-docs.pages.dev |
| Branch Preview URL: | https://docs-new-locale-string.dyte-docs.pages.dev |
swapnilmadavi
requested changes
Aug 8, 2024
docs/flutter/meeting-locale.mdx
Outdated
Comment on lines
34
to
35
| | `key` | `value` | | ||
| | ----- | ------- | |
There was a problem hiding this comment.
(change-request): Can we remove the repeated table header?
| | "back" | "_\<locale-word>_" | | ||
| | "waitingForTheHostToLetYouIn" | "_\<locale-word>_" | | ||
| | "shareScreen" | "_\<locale-word>_" | | ||
| | "stopSharing" | "_\<locale-word>_" | | ||
|
|
||
| 3. All set, run the app and view the UI Kit in the desired language! |
There was a problem hiding this comment.
(suggestion): The 3rd point feels a bit out-of-flow due to the big table between the 2nd & 3rd point.
How about moving the 3rd point above and keeping the "strings table" under a separate header at the bottom of the page?
There was a problem hiding this comment.
Sure, we can do that, it justs mentions that to run the app. Don't think it'll make much of a difference.
Comment on lines
7
to
14
| { | ||
| "version": "0.7.8", | ||
| "createdAt": 1721673000, | ||
| "fixes": [ | ||
| "Make listeners list safe from modification while callbacks in progress", | ||
| "Participant video sync in `DyteParticipantTile` component." | ||
| ] | ||
| }, |
There was a problem hiding this comment.
(doubt): Same changelog as v0.7.7?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description