Unify rr-opts and gdb-opts behavior.
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like unifying across commands. Can you push that to this PR? |
|
Oh, thanks for the quick reply :) Now its unified. |
This was referenced Jan 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation to #12.
I think the arguments should have the same syntax for specifying them.
Now, both can be specified with their specific flag:
cargo rr replay --rr-opts="-s 1234" --gdb-opts="-a"Note that equal signs are required to eliminate ambiguity. Otherwise clap would parse
--rr-opts "-s 1234"as specifying the -s flag.In the unified-across-commands branch I have also adjusted the behavior to be consistent, you can decide if that makes sense, given that the other commands do not support
gdb-optsand onlyrr-opts