dash parser attributes and utility functionality #18
Conversation
| * @param expectedAttributes The expected attributes based on the DASH spec | ||
| * @returns A parsed and formatted list attributes. | ||
| */ | ||
| const formatAttributes = ( |
There was a problem hiding this comment.
This is a key change. I think it would be nice if we could have all of the expected attributes in a separate file and then have some logic to utilize those to parse and format the attributes here.
There was a problem hiding this comment.
So basically, if some attribute has a default value - we should add it to the parsedManifest initializer since typescript will warn us because we should mark such fields as available instead of optional.
By having a separate map for attributes, we create two different sources of truth here.
I believe each Processor should keep its own list of static attribute keys, and it can also maintain its own set of required attributes...
I think we should go with the same approach we already have with hls-parser:
We can ensure that required attributes are presented by utilizing safeProcess protected method. I suggest simply re-using the same approach, and we can probably share it between 2 parsers in the feature.
| parsedManifest.availabilityEndTime = Date.parse(availabilityEndTime); | ||
| } | ||
| const attributes = formatAttributes(tagInfo.tagAttributes, MPDAttributes); | ||
| sharedState.attributes = attributes; |
There was a problem hiding this comment.
I think we will eventually want these attributes to live on the Representation object in the parsed manifest. Therefore, I am just writing it to the state. I'll work on improving this in the future.
| import { parseDuration, parseDate } from './utils/time'; | ||
|
|
||
| interface Parsers { | ||
| [key: string]: (value: string) => string | number; |
There was a problem hiding this comment.
We can probably make it typed
| private static readonly MIN_BUFFER_TIME = 'minBufferTime'; | ||
| private static readonly XMLNS = 'xmlns'; | ||
| private static readonly XMLNS_XSI = 'xmlns:xsi'; | ||
| private static readonly XSI_SCHEMA_LOCATION = 'xsi:schemaLocation'; |
There was a problem hiding this comment.
we can def omit this xmlns, xmls-xsi and xsi-schema-location
Mainly a PR to plugin most of my changes with Dzianis'.