fix java_env_set_session #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, using:
kind of misses the point, as it almost initialises rJava. That is, after this check, no matter what we do with environment variables,
rJava::.jinit()will NOT pick up the Java from JAVA_HOME or any other related environment variables.So we resort to just checking if the user has
{rJava}installed AND loaded in the namespace and give warning. Loading the packages that rely on{rJava}does not usually attach{rJava}. So if the user has already tried some functions from the{rJava}-dependent package that initialised{rJava}or did it directly withrJava::.jinit(), they will have{rJava}attached. If they did not do any of that,{rJava}is unlikely to be attached and we can hide the warning about impossibility to change the Java version in the current session.