Work profile fix #231
Merged
Work profile fix #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…permissions screen anymore. Also bumped version number.
shankari
approved these changes
May 16, 2024
Comment on lines
+126
to
+127
| public static boolean checkWorkProfile(final Context ctxt) { | ||
| DevicePolicyManager devicePolicyManager = (DevicePolicyManager) ctxt.getSystemService(ctxt.DEVICE_POLICY_SERVICE); |
There was a problem hiding this comment.
I am fine with merging this as-is so that we don't over-engineer this, but in the future, we may want to/need to return the admin information. But it is fine for now, since it follows the format of the other checks as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue.
Testing Done
I successfully went through the permissions process for the app while installed on both a work profile and personal profile.