Couple of native code fixes

[shankari]

Crash reported in the app store

Related code is:

    NSAssert([lastLocArray count] > 0, @"Found no locations while ending trip!");

UI overlaps the cutout for the camera on newer iPhone versions

Force-kill message is too long to view but doesn't show details when app is opened

Looks like I fixed this anyway....

overlap	force kill

[shankari]

cutout overlap seems to require viewport-fit=cover
Not sure if that works with ionic 1

[shankari]

For the first issue, let's replace the assert by

    if ([lastLocArray count] == 0) {
        StatsEvent* se = [[StatsEvent alloc] initForEvent:@"no_locations_while_ending_trip"];
        [[BuiltinUserCache database] putMessage:@"key.usercache.client_error" value:se];
    }

[shankari]

There are a bunch of additional asserts in the transition notifier code.
Let's replace all of them for now (already removed one in 5a765547f58a8e73668189ffc8d1a0040bfdb3c5; let's replace the others with client stats as well).

We may also consider removing the plugin completely since nobody seems to want to use it.

[shankari]

for the second issue:
https://developer.mozilla.org/en-US/docs/Web/HTML/Viewport_meta_tag

https://udn.realityripple.com/docs/Web/CSS/@viewport/viewport-fit

The viewport is scaled to fill the device display. It is highly recommended to make use of the safe area inset variables to ensure that important content doesn't end up outside the display.

[shankari]

So ionic1 does not support the safe area inset variables

$ grep -r safe-area-inset-top css/ js/
$

Tried to add them manually per instructions:
https://developer.mozilla.org/en-US/docs/Web/CSS/env
https://udn.realityripple.com/docs/Web/CSS/env

body {
  padding:
    env(safe-area-inset-top, 20px)
    env(safe-area-inset-right, 20px)
    env(safe-area-inset-bottom, 20px)
    env(safe-area-inset-left, 20px);
}

But they are overridden by app.css from www/build/app.css.

All the stuff in www/build/ is related to habitica.
https://github.com/e-mission/e-mission-phone/commits/master/www/build/app.css

Can we just remove it, or will it break anything else?

[shankari]

removed, next overridden by entry is styles.css
removed that as well.

It now works but looks ugly

and we can't even see the tab bar at the bottom

[shankari]

Turned out that this was because the ion-view was set to a height of 100%, which caused it to go off the screen if we changed the padding of the body.

Further changes:

• view container height = 100% - safe-area-inset-top
• this causes the scroll bar inside the view to not be at 100%, so we set its height to 100% - 50px as well
• and then we make all of this apply only to iOS https://stackoverflow.com/questions/27432360/how-to-isolate-specific-platforms-using-css-selectors-in-the-ionic-framework to avoid regressions on android

[shankari]

No body	Body but no scroll content height	Body but with a limited offset	Everything + scroll height

[shankari]

Apparently, the right way to select by class is:

body.platform-ios {
  padding-top: calc(env(safe-area-inset-top) / 2);
  margin: 0 10px 0 0;
}

.platform-ios .view-container {
  height: calc(100% - (env(safe-area-inset-top) / 2));
}

.platform-ios .scroll-content {
    height: calc(100% - 50px);
}

[shankari]

Looks fine on both android and iOS

android	iOS

[shankari]

One final issue: Giving additional notification privileges causes the notification check on iOS to fail.
We currently request

    return [UIUserNotificationSettings
            settingsForTypes:UIUserNotificationTypeAlert|UIUserNotificationTypeBadge
            categories:nil];

which maps to a types of 5
https://developer.apple.com/documentation/uikit/uiusernotificationtype?language=objc

If the user allows sound as well, the requested types are 5, but the provided types are 7, which causes this check to fail

return requestedSettings.types == currSettings.types;

Couple of potential fixes:

• request everything including sound
• check for provided > requested
  • this could be incorrect because UIUserNotificationTypeSound|UIUserNotificationTypeAlert = 6 > 5 but it means that we don't have the badge permission
• check for the actual permissions using bitwise operators
  • this should be actual settings & requested settings = requested settings

[shankari]

There seems to be a minor difference between CanBikeCO and master - CanBikeCO does not need the scroll-content fix. And in fact, if it has the scroll-context fix, it breaks because we cannot see the lowest card fully. Fortunately, android is not affected.

with scroll-content override	without scroll-content override	android

[shankari]

@asiripanich here are some fit and finish fixes for iOS, including a crash and the "notch" UI on recent model phones.
LMK if you notice any of them!

[asiripanich]

@shankari thanks! I will get our team to test this.