Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join webapp does not display error messages in Spanish #905

Open
shankari opened this issue May 20, 2023 · 0 comments · Fixed by e-mission/nrel-openpath-join-page#15
Open

join webapp does not display error messages in Spanish #905

shankari opened this issue May 20, 2023 · 0 comments · Fixed by e-mission/nrel-openpath-join-page#15

Comments

@shankari
Copy link
Contributor

In the join page, we load the english version by default, so if there is an error in the parameters passed in, the error message is in English and the page language changes to English. However, even if the language is changed back to Spanish, the error message stays in English because we don't try to re-generate the token, and the error message is filled in using $.i18n instead of data-i18n.

And we can't translate the error when changing the language because we don't know the reason for the error.

There are multiple possible fixes:

  • encoding the language as a query param so that when we reload, we reload in Spanish
  • caching the error message
  • ...

Let's punt on this for now and fix it later.
@shankari shankari changed the title Minor bug in join page i18n join webapp does not display error messages in Spanish May 20, 2023
@shankari shankari mentioned this issue May 20, 2023
Open
shankari added a commit to e-mission/nrel-openpath-join-page that referenced this issue May 20, 2023
@shankari
🌐 Translate the error messages on the join page as well
8d3f116 
They are not actually used, since:
- I have never seen the clipboard action fail
- We always load the page first in English

But at least when we fix e-mission/e-mission-docs#905
we are ready for things to work

This is the final final fix for
e-mission/e-mission-docs#850
@shankari shankari mentioned this issue May 20, 2023
Merged
@shankari shankari reopened this May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌐 Translate the error messages on the join page as well e-mission/nrel-openpath-join-page
1 participant
@shankari