⬆️ ☁️ Upload Service -- rewrite and testing #1053
Conversation
hoping to avoid naming problems when creating the new ts service by the same name
starting to convert the service, but running into a fair number of issues, especially because of complex ionic popups
the upload service called for a log at the error level, adding support for that in logger.ts
could not find file "uploadService.js", needed to carry over the name change to "nguploadService.js"
using async await is a clearer way of handling the asynchronous processes in this file, so it is easier to figure out what is happening and properly set up the typescript version of this service.
we need to take a reason, so why not take it and then call the function? This workflow attempts to take user input in a modal and then pass it to the service's uploadFile function -- note, currently broken!!!
…into services_rewrite
This now appears to be working with the dev server, as the POST requests are going through successfully The next step is testing and potentially polishing the message popups to the user
there were two errors in VScode, which were also tripping the tests up when I tried to run the uploadFile function -- resolving these did not make the tests run, but it did get past the first of the errors!
tests are not fully running yet, but making progress and need to save before getting the mocks from a remote branch
…into services_rewrite
…to services_rewrite
needed to mock window['resolvelocalfilesystem'] as well as window['cordova'].file
After a lot of work ironing out a mock for the file system layers, a working mock and test has been established the "reason" passed through remains present throughout the process, confirming in at least a small way that this works
the dev ui server wouldn't run because there were two imports from react-nativ-paper, probably form a bad merge resolution
wrapping up the basic implementation and testing of this upload service, adding comments for clarity
|
This is now running, and passing the test I created for it. It relies heavily on mocks, specifically for the file reading, fetching, and logging. The test is simple, but proves that parameter data is being passed through the function in the expected manner. Window.alert is the current mechanism for notifying the user of progress or changes in the upload process, to be reconsidered based on #992. |
need to pass the file in its original form and not stringify it in order for the data to actually make it to the server This change is pending restoration of the reason and tz paramenters
In the previous commits, I altered the call to POST, so I needed to alter the way I mocked that call!
|
This is working now!! Both in the emulator and in the test I wrote. The UI will need some re-vamping (window alerts are not a great way of notifying the user of progress) when we get this back into production, but it is now Reactified and functional. |
|
This PR is dependent on ✏️ Rewrite KVStore, ClientStats, and CommHelper, that one should be merged first. |
|
Can you change the target of this PR to some other branch, then change it back to (#1040 is merged but my commits are still showing up in this PR. I've discovered that toggling the branch forces Github to update the diff) |
|
resolved merge conflicts |
this mock was confusing, so I've added comments to indicate what the two parts do. Perviously, there was no timeout in the if, only in the else, now they are consistent
we want to set the message right away, then have a delay on the response itself
See: upload service rewrite for discussion.
While we do not use this anywhere in production now, we would like to restore it at some point and therefore still need tests and a
tsversion of this file.Writing the mocks for the file system was difficult, but I think I got something figured out that allows the code to run and to verify that this is working, at least behaving as expected on the phone side.