-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating TestNominatim.py #929
Commits on Jul 21, 2023
-
Creating an integration test to make sure nominatim calls work properly. The tests call various classes from Nominatim.py and ensures that the format of the responses are as expected with the current calling format.
Configuration menu - View commit details
-
Copy full SHA for ceaddc7 - Browse repository at this point
Copy the full SHA ceaddc7View commit details
Commits on Aug 10, 2023
-
Multiple changes for nominatim testing
save_ground_truth.py: added parser argument line so that ground truth can be saved successfully using "diary" argument. Generated a ground truth file while testing save_ground_truth.py. Modified nominatim.py to remove all google based functionality. Created new docker-compose.yml, Dockerfile, and a few shell scripts in emission/integrationTests to run the integration tests while starting Nominatim server through docker container. nominatim-docker-test.yml sets up the servers in GH actions and runs docker-compose. runIntegrationTests.sh uses the discover method to run all tests in emission/integrationTests. TestNominatimBeta.py compares the result of a reverse geocoding call to nominatim with an expected output. removed ports from docker-compose.tests.yml per Shankari's instruction.
Configuration menu - View commit details
-
Copy full SHA for dbce159 - Browse repository at this point
Copy the full SHA dbce159View commit details
Commits on Aug 11, 2023
-
Cleaning up the PR to try out nominatim test.
Moved nominatim-docker-test.yml to github workflows directory and set path to docker compose. Edited docker-compose.yml to reflect rhode island data instead of norcal; updated ports. Added environment variable to dockerfile (not quite polished yet) so that nominatim query can be run with localhost when appropriate.
Configuration menu - View commit details
-
Copy full SHA for 067158c - Browse repository at this point
Copy the full SHA 067158cView commit details
Commits on Aug 14, 2023
-
Trying to get nominatim-docker-test.yml to run in GH actions with small syntax changes. Also changing the repo from which docker builds to current directory.
Configuration menu - View commit details
-
Copy full SHA for b7e77fb - Browse repository at this point
Copy the full SHA b7e77fbView commit details
Commits on Aug 15, 2023
-
Removed unused imports. Added a line that temporarily sets the query URL in eco to that of the environment variable, just for the purpose of testing. This way, nominatim.json can stay the same, while the testing environment variable can still be used and modified easily. Also resolved hardcoding of nominatim URL per Shankari's request.
Configuration menu - View commit details
-
Copy full SHA for 0aed377 - Browse repository at this point
Copy the full SHA 0aed377View commit details -
Added os import, removed print statement.
Configuration menu - View commit details
-
Copy full SHA for 01a3b4d - Browse repository at this point
Copy the full SHA 01a3b4dView commit details -
Changed file to run on PR (temporarily) to see if it will run.
Configuration menu - View commit details
-
Copy full SHA for fd453e6 - Browse repository at this point
Copy the full SHA fd453e6View commit details
Commits on Aug 17, 2023
-
Python command not found test + compose updates
- Added nominatim network in docker-compose so that db and nominatim are separated. This should allow them to run on different ports, while communicating with the web server. - Testing to see where pythonpath is set in GH actions/if we need to specify in the runner specs.
Configuration menu - View commit details
-
Copy full SHA for ce51ed8 - Browse repository at this point
Copy the full SHA ce51ed8View commit details -
Environment variables + prints
Dockerfile: updated query url to access the nominatim container while running on web server. start_integration_tests: moved a commented out section. Nominatim.py: Added environment variable to replace nominatim.json file. added multiple prints to (hopefully) see what's going on with the tests.
Configuration menu - View commit details
-
Copy full SHA for 7efa164 - Browse repository at this point
Copy the full SHA 7efa164View commit details
Commits on Aug 21, 2023
-
Environment variable setup, small testing changes, removing TestNomin…
…atimBeta. Nominatim.py: removing prints TestNominatimBeta: removed and combined with testnominatim.py runIntegrationTests.sh: modified to only call TestNominatim.py, since the other integration tests don't work yet. TestNominatim.py: updated environment variable functionality to work with both AWS and the testing environment. Modified test_geocode to only call geocode function once. Changed test query for test_get_json_geo so that it would return a list.
Configuration menu - View commit details
-
Copy full SHA for f8e9512 - Browse repository at this point
Copy the full SHA f8e9512View commit details
Commits on Aug 22, 2023
-
Directly testing two different potential solutions to the URL query issue in GH actions. Will change the environment variable for NOMINATIM_QUERY_URL when I find the right way to call the container in the GH actions network.
Configuration menu - View commit details
-
Copy full SHA for 6b9d98d - Browse repository at this point
Copy the full SHA 6b9d98dView commit details -
TestNominatim.py: commented out irrelevant tests that won't help with troubleshooting Nominatim.py: Added port to nominatim call. Trying out calling by image name instead of name of container. runIntegrationTests.sh: Added command to list out processes on 8080
Configuration menu - View commit details
-
Copy full SHA for 2bb9e66 - Browse repository at this point
Copy the full SHA 2bb9e66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b76ac1 - Browse repository at this point
Copy the full SHA 3b76ac1View commit details -
Specifying nominatim-network is separated from the service name, nominatim. It is possible that this was causing an issue with accessing the network.
Configuration menu - View commit details
-
Copy full SHA for 927a6f7 - Browse repository at this point
Copy the full SHA 927a6f7View commit details -
Trying to remove universal network at the bottom of the file, and removing http.
Configuration menu - View commit details
-
Copy full SHA for 1ada684 - Browse repository at this point
Copy the full SHA 1ada684View commit details -
Modifying network to add a bridge driver, specifying network names, adding link to nominatim network from web server, and assigning web server its own ports. All of these changes are in an attempt to allow web server to access the nominatim container and make an API call.
Configuration menu - View commit details
-
Copy full SHA for c9135ed - Browse repository at this point
Copy the full SHA c9135edView commit details -
Since my network was working properly locally, I'm now thinking that the issue has to do with timing. I don't think the rhodeisland-nominatim container had enough time to setup and wait/listen, which caused the connection to be refused. Changes: start_integration_tests: removing echoes dockerfile: reverting to old environment variable compose: removing version(hopefully this is allowed) and reverting everything except adding condition check. This should cause web-server to wait for the nominatim service to be up and running before trying to connect. We will see!
Configuration menu - View commit details
-
Copy full SHA for ccc1c46 - Browse repository at this point
Copy the full SHA ccc1c46View commit details -
Health check + env variable moved
docker-compose: Added healthcheck to nominatim service, in tandem with restart policy for web server. Hopefully, this gives nominatim enough time to initialize. Also added environment variable for query url. Dockerfile: removed environment variable, and added to compose.
Configuration menu - View commit details
-
Copy full SHA for ed91603 - Browse repository at this point
Copy the full SHA ed91603View commit details -
Added --wait to docker-compose command, which supposedly will cause the other containers to wait for my nominatim service to pass its health check. Removed restart on failure, which isn't necessary with wait.
Configuration menu - View commit details
-
Copy full SHA for b072a89 - Browse repository at this point
Copy the full SHA b072a89View commit details -
start_integration_tests: Added sleep command to directly delay starting the tests, since docker methods weren't working. This worked locally, and I could see where the health checks were taking place. Will be helpful to, at the very least, see how long nominatim needs to get started up. nominatim-docker-test.yml: Reverted to old command. TestNominatim.py: Un-commented other tests.
Configuration menu - View commit details
-
Copy full SHA for 6794eae - Browse repository at this point
Copy the full SHA 6794eaeView commit details -
Giving nominatim twice as long to initialize. I cannot get my local container to not build with old image data, despite deleting the old images.
Configuration menu - View commit details
-
Copy full SHA for 93420dc - Browse repository at this point
Copy the full SHA 93420dcView commit details
Commits on Aug 24, 2023
-
Adding mock to bypass place_id.
A small change while I'm working on implementing dockerize. Mock should bypass the issue with the place_id, which should get the tests to work!! :)
Configuration menu - View commit details
-
Copy full SHA for 9af4e2e - Browse repository at this point
Copy the full SHA 9af4e2eView commit details
Commits on Aug 28, 2023
-
Testing dockerize. Added docker install to dockerfile, and added a line in our start_integration_tests.sh to wait for a 200 from the rhodeisland-nominatim container. Here's what it looks like on my machine: ``` integrationtests-web-server-1 | 2023/08/28 18:27:10 Waiting for: http://rhodeisland-nominatim:8080 integrationtests-web-server-1 | 2023/08/28 18:27:10 Received 200 from http://rhodeisland-nominatim:8080 ``` Additionally, my tests passed locally: ``` integrationtests-web-server-1 | Ran 6 tests in 0.344s integrationtests-web-server-1 | integrationtests-web-server-1 | OK ```
Configuration menu - View commit details
-
Copy full SHA for b6bb7cb - Browse repository at this point
Copy the full SHA b6bb7cbView commit details -
Adding a specified timeout that's longer than the default (10s) so that the container has a chance to start up.
Configuration menu - View commit details
-
Copy full SHA for 867287d - Browse repository at this point
Copy the full SHA 867287dView commit details -
Longer timeout test to see if nominatim will have time to initialize.
Configuration menu - View commit details
-
Copy full SHA for bdc70ae - Browse repository at this point
Copy the full SHA bdc70aeView commit details
Commits on Sep 14, 2023
-
Fake place creation + geofabrik testing functionality
nominatim-docker-test.yml: added environment variable for the geofabrik query url with GitHub actions secrets. we will see if this works in this commit. docker-compose.yml: commented out healthcheck because it isn't currently doing anything useful to delay the start. Should remove completely once docker commit is working. TestNominatim.py: added functionality for geofabrik calls with GH actions secrets. Added creation of a fake place to use for testing of get_filtered_place. Added test comparing geofabrik and nominatim hard-coded calls (these may not be possible from within the container so might be removed) Added test for get_filtered_place in clean_and_resample, which passes in the fake place created above. Modified test_get_json_reverse to only check the display name for now.
Configuration menu - View commit details
-
Copy full SHA for 86d51e4 - Browse repository at this point
Copy the full SHA 86d51e4View commit details -
nominatim-docker-test: Updating geofabrik url variable, in hopes that it will be able to be passed into a call in TestNominatim.py. I have looked into it more, and I'm not sure if GH actions allows this. nominatim.py: Realized that some of my assertion errors might be related to the nominatim url environment variable not getting set properly locally, so comparing local url to the one produced in github actions. TestNominatim,py: Changing expected result for get_filtered_place. Difference was due to my error.
Configuration menu - View commit details
-
Copy full SHA for eba9d4d - Browse repository at this point
Copy the full SHA eba9d4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18ba878 - Browse repository at this point
Copy the full SHA 18ba878View commit details
Commits on Sep 15, 2023
-
Env variable testing + changing test_get_json_geo
Added multiple tests to see if I can access the fake API key I added to GH actions secrets. Modified the test for the get_json_geo function to only look for the name of the returned place.
Configuration menu - View commit details
-
Copy full SHA for 53c3e1e - Browse repository at this point
Copy the full SHA 53c3e1eView commit details -
Temporarily reinstating sleep; re-removing wikipedia import
Configuration menu - View commit details
-
Copy full SHA for 7c3fcbd - Browse repository at this point
Copy the full SHA 7c3fcbdView commit details -
trying to get workflow to go on my nominatim branch
Seeing if this causes the workflow to run in a different area.
Configuration menu - View commit details
-
Copy full SHA for cc09fee - Browse repository at this point
Copy the full SHA cc09feeView commit details -
Trying to get workflow unstuck
Two workflows became stuck with my last change. Trying to revert change and see if they become unstuck.
Configuration menu - View commit details
-
Copy full SHA for dbdd359 - Browse repository at this point
Copy the full SHA dbdd359View commit details
Commits on Sep 18, 2023
-
docker-compose.yml: Adding healthcheck back in because build failed when I removed it. nominatim-docker-test.yml: changing workflow to trigger only on push to nominatim, since I'm hoping to only run this test on my test branch instead of the main branch.
Configuration menu - View commit details
-
Copy full SHA for 4b1608d - Browse repository at this point
Copy the full SHA 4b1608dView commit details -
Trying to see if there's a way for me to get this workflow to only run in my forked repository for now.
Configuration menu - View commit details
-
Copy full SHA for 9b2ad65 - Browse repository at this point
Copy the full SHA 9b2ad65View commit details -
Apparently scheduled runs won't run on forked branches, so I'm removing the schedule to see if it will run on my forked branch. This is important, because I need to get the API keys working.
Configuration menu - View commit details
-
Copy full SHA for 9f4f819 - Browse repository at this point
Copy the full SHA 9f4f819View commit details -
Trying to get this workflow to run!!!
I think I understand what's happening now and why my workflow won't run on my fork. Added a dummy print to see if this triggers anything, since my last change was just to the workflow file (which GH might not recognize as a real push?)
Configuration menu - View commit details
-
Copy full SHA for 0283672 - Browse repository at this point
Copy the full SHA 0283672View commit details -
Test still not running properly. Trying: yml: Just run on nominatim push. Hoping it will work now. sh: adding some more echoes to see if I can tell where the problem is arising. I've looked through the old commits and I can't see what would've gone wrong.
Configuration menu - View commit details
-
Copy full SHA for dbe4fa4 - Browse repository at this point
Copy the full SHA dbe4fa4View commit details -
I scoured through everything and added some prints. It looks like tail -f is messing up the web server's ability to make requests, so I'm commenting it out again. Hopefully this fixes the issue!!
Configuration menu - View commit details
-
Copy full SHA for e89ae7e - Browse repository at this point
Copy the full SHA e89ae7eView commit details -
Test worked! Now onto the variables.
Currently successfully running all of the tests in my repo only, so I can cancel the jobs if need be. Also, I am now able to test out using API keys in the workflow. It looks like the `TEST_ENVVAR = os.environ["TEST_ENVVAR"]` method is unrecognized/invalid, so I'm removing it and trying out the .get method instead.
Configuration menu - View commit details
-
Copy full SHA for 5cf4a0d - Browse repository at this point
Copy the full SHA 5cf4a0dView commit details -
Verified with last test that the .get method is the preferred way to set the variable. Trying a few ways to print the variables to see how it looks; I'm nervous because the last attempt printed "None". Added a print without any secrets to see if it's setting these variables at all.
Configuration menu - View commit details
-
Copy full SHA for 2c7418e - Browse repository at this point
Copy the full SHA 2c7418eView commit details
Commits on Sep 19, 2023
-
Seeing if something as simple as a string gets carried over to other files, or if it's stuck in the workflow file.
Configuration menu - View commit details
-
Copy full SHA for 2b0c1e6 - Browse repository at this point
Copy the full SHA 2b0c1e6View commit details -
Adding spaces to see if that fixes the secret not being set. Also, trying to access the variables directly without using the get method.
Configuration menu - View commit details
-
Copy full SHA for 1ddc01b - Browse repository at this point
Copy the full SHA 1ddc01bView commit details -
Removing prints that caused workflow to fail
Configuration menu - View commit details
-
Copy full SHA for 72e4b77 - Browse repository at this point
Copy the full SHA 72e4b77View commit details -
Trying a few more things before I give up on GH actions secrets. Moving the environment variables to be after the run command, as that's what I've seen in many examples. If that doesn't work, I'm going to try to move it to the jobs section of the workflow file.
Configuration menu - View commit details
-
Copy full SHA for 60d2b6b - Browse repository at this point
Copy the full SHA 60d2b6bView commit details -
Moved environment variables to jobs section to hopefully make them accessible throughout the workflow. Added an echo test to see if the variables are carried to the steps. Added a print to TestNominatim.py to see if there are any environment variable keys available.
Configuration menu - View commit details
-
Copy full SHA for 8f2c032 - Browse repository at this point
Copy the full SHA 8f2c032View commit details -
Trying to pass in environment variable
It's a stretch but this could potentially be a way to pass in the api key. We will see
Configuration menu - View commit details
-
Copy full SHA for f29c601 - Browse repository at this point
Copy the full SHA f29c601View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc5d0f7 - Browse repository at this point
Copy the full SHA fc5d0f7View commit details -
Passing in the environment variable to the run command for docker compose, and then adding the variable to the environment again in the docker-compose.yml
Configuration menu - View commit details
-
Copy full SHA for ed51883 - Browse repository at this point
Copy the full SHA ed51883View commit details -
Removing brackets around test key variable.
Configuration menu - View commit details
-
Copy full SHA for e61066b - Browse repository at this point
Copy the full SHA e61066bView commit details -
Realized I put the test key in the wrong service. Moving to see if it could finally work!
Configuration menu - View commit details
-
Copy full SHA for 8e0c222 - Browse repository at this point
Copy the full SHA 8e0c222View commit details
Commits on Sep 20, 2023
-
Trying out setting the environment variable just once, in the docker compose line. I have high hopes for this test :)
Configuration menu - View commit details
-
Copy full SHA for db2ea77 - Browse repository at this point
Copy the full SHA db2ea77View commit details -
Trying again but actually commenting out the env section!
Configuration menu - View commit details
-
Copy full SHA for 182132f - Browse repository at this point
Copy the full SHA 182132fView commit details -
Using what I learned from the test key and formatting for geofabrik. Also added a print if the key is not formatted properly. Removed a bunch of extra prints and test variables. I am really hopeful that the test_geofabrik_api test will finally get to run!
Configuration menu - View commit details
-
Copy full SHA for aa11c5a - Browse repository at this point
Copy the full SHA aa11c5aView commit details -
Modifying test_geofabrik_and_nominatim
Modified test substantially to verify that multiple k,v pairs are equal. The raw json results are substantially different, so it is not viable to compare them. Test is passing locally.
Configuration menu - View commit details
-
Copy full SHA for b9d500e - Browse repository at this point
Copy the full SHA b9d500eView commit details -
Replaced address called with one that I know the container has (since the function is used elsewhere in the container). Decided to use the same format as I used for test_geofabrik_and_nominatim to compare the results. Test is passing locally.
Configuration menu - View commit details
-
Copy full SHA for baa6bee - Browse repository at this point
Copy the full SHA baa6beeView commit details
Commits on Sep 21, 2023
-
Only looking at the first 30 characters of the display name at the moment so that the test will pass
Configuration menu - View commit details
-
Copy full SHA for 7a1974f - Browse repository at this point
Copy the full SHA 7a1974fView commit details -
Changing to the first 71 characters + constraining the docker result as well.
Configuration menu - View commit details
-
Copy full SHA for e941b5f - Browse repository at this point
Copy the full SHA e941b5fView commit details
Commits on Sep 26, 2023
-
Using new container with preloaded data
Since the tests are passing, I decided to try out docker commit to further optimize test time. Depending on how long it takes to build the container, I might remove the dockerize functionality. Also added some comments about what the tests do.
Configuration menu - View commit details
-
Copy full SHA for 8377b59 - Browse repository at this point
Copy the full SHA 8377b59View commit details -
Created a new image without the wikipedia info, since this apparently changed how the container was created. I'm not sure if docker commit is actually going to make this faster based on the logs from my last test.
Configuration menu - View commit details
-
Copy full SHA for ebb77f5 - Browse repository at this point
Copy the full SHA ebb77f5View commit details
Commits on Sep 27, 2023
-
Created a new image using highly controlled container. Seeing what happens when I push this; I might have to change the entrypoint, but I'm hoping not.
Configuration menu - View commit details
-
Copy full SHA for 90b7063 - Browse repository at this point
Copy the full SHA 90b7063View commit details -
Testing out new entrypoint. Also fixed some of the minor changes from Shankari's code review.
Configuration menu - View commit details
-
Copy full SHA for 5fbf161 - Browse repository at this point
Copy the full SHA 5fbf161View commit details -
Created a new image and added the required file to skip download. Going to see how this one works :)
Configuration menu - View commit details
-
Copy full SHA for 4c9c915 - Browse repository at this point
Copy the full SHA 4c9c915View commit details
Commits on Sep 28, 2023
-
compose: Removing healthcheck since the new image is running much faster start tests script: Modified with Shankari's suggestions + removing sleep functionality nominatim.py: updating URL + adding potentially helpful print statements workflow file: adding in commented section for schedule; will un-comment out once everything is good!
Configuration menu - View commit details
-
Copy full SHA for ec73542 - Browse repository at this point
Copy the full SHA ec73542View commit details -
Removing the ground truth file + fixing a syntax error in my last commit.
Configuration menu - View commit details
-
Copy full SHA for 4d46b20 - Browse repository at this point
Copy the full SHA 4d46b20View commit details -
Fixing print; removing db port
Seeing how it runs when I remove the database port.
Configuration menu - View commit details
-
Copy full SHA for d1bdecb - Browse repository at this point
Copy the full SHA d1bdecbView commit details -
Changing services per shankari's requests one step at a time. Removing the webserver export now
Configuration menu - View commit details
-
Copy full SHA for 8cc7187 - Browse repository at this point
Copy the full SHA 8cc7187View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88b0030 - Browse repository at this point
Copy the full SHA 88b0030View commit details
Commits on Sep 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8a6d339 - Browse repository at this point
Copy the full SHA 8a6d339View commit details
Commits on Oct 3, 2023
-
createfakeplace.py + removing dockerize + setup_integrationtests.sh
docker-compose.tests.yml: removing whitespace (My test doesn't use this file, so it must have been added there on accident) dockerfile: removing dockerize and extra print start_integration_tests: removing dockerize wait command and some extra whitespaces setup_integrationtests.sh: created a new shell script that's separate from setup_tests.sh. essentially the same, but added a line to run createfakeplace.py createfakeplace.py: creates a fake place to be used in testnominatim.py testnominatim.py: added functionality for createfakeplace.py.
Configuration menu - View commit details
-
Copy full SHA for 1e90c65 - Browse repository at this point
Copy the full SHA 1e90c65View commit details -
Removing another whitespace that I didn't see previously :)
Configuration menu - View commit details
-
Copy full SHA for 5050a66 - Browse repository at this point
Copy the full SHA 5050a66View commit details -
Removing the db.conf file and updating a comment in testnominatim.py
Configuration menu - View commit details
-
Copy full SHA for 518fdb3 - Browse repository at this point
Copy the full SHA 518fdb3View commit details
Commits on Oct 9, 2023
-
I am almost positive I have the URL formatting how it is supposed to be. All of the tests are passing locally. Here's what I've done: TestNominatim.py: - Created a new module that sets the query URL to be used in nominatim.py and reloads nominatim.py. This allows the user to call the various nominatim services anywehre in the code, without modifying nominatim.py. - added setup function for consistency with other tests docker-compose: added query URLs as environment variables for the web-server service. nominatim.py: set the nominatim_query_url as an environment variable in a more simple way.
Configuration menu - View commit details
-
Copy full SHA for 09e240f - Browse repository at this point
Copy the full SHA 09e240fView commit details -
After last push, now that I know it works, removing some unnecessary things and reinstating the testing schedule.
Configuration menu - View commit details
-
Copy full SHA for 80519bb - Browse repository at this point
Copy the full SHA 80519bbView commit details
Commits on Oct 11, 2023
-
- Deleting createfakeplace.py and setup_integrationtests.sh - Reverting to setup_tests.sh in start_integration_tests.sh - Moving creation of fake place to TestNominatim.py setup function - Adding logging for query URL and modifying a print in nominatim.py
Configuration menu - View commit details
-
Copy full SHA for d31df8c - Browse repository at this point
Copy the full SHA d31df8cView commit details -
Trying out running the test on only one network. Also adding in run on push to nominatim branch so that the test runs again!
Configuration menu - View commit details
-
Copy full SHA for efb963c - Browse repository at this point
Copy the full SHA efb963cView commit details -
Workflow wasn't going on last push due to changes to schedule, so reverting temporarily.
Configuration menu - View commit details
-
Copy full SHA for a55a9ad - Browse repository at this point
Copy the full SHA a55a9adView commit details -
Reverting workflow (final push?!)
This could be it! Reverting to the scheduled runs.
Configuration menu - View commit details
-
Copy full SHA for 3ce7e5b - Browse repository at this point
Copy the full SHA 3ce7e5bView commit details
Commits on Oct 18, 2023
-
Committing Shankari's suggestion Co-authored-by: shankari <shankari@eecs.berkeley.edu>
Configuration menu - View commit details
-
Copy full SHA for b779c1f - Browse repository at this point
Copy the full SHA b779c1fView commit details -
Trying out removal of port 8080 now that all of the services are on the same network. Hopefully, the container can call by just the name of the container and not expose the port. Also adding to run on push to one of the paths so that the test runs.
Configuration menu - View commit details
-
Copy full SHA for 1c7cb3c - Browse repository at this point
Copy the full SHA 1c7cb3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 693407e - Browse repository at this point
Copy the full SHA 693407eView commit details -
Despite being on one network, calling the container by name might have messed things up. Also adding a print for debugging.
Configuration menu - View commit details
-
Copy full SHA for 70ff4ab - Browse repository at this point
Copy the full SHA 70ff4abView commit details
Commits on Oct 19, 2023
-
Slightly modifying the workflow to see if the API key can be pulled to the workflow successfully.
Configuration menu - View commit details
-
Copy full SHA for fa508ad - Browse repository at this point
Copy the full SHA fa508adView commit details -
Replacing the API key with a known working repo secret to see if the problem is GH accessing the repo secrets, or something with the way the secret was put in.
Configuration menu - View commit details
-
Copy full SHA for a6be71a - Browse repository at this point
Copy the full SHA a6be71aView commit details -
Setting secret as env var in workflow file
Setting the geofabrik api key as an environment variable prior to running compose. Hopefully, this will pull the secret properly and allow it to be used in the workflow.
Configuration menu - View commit details
-
Copy full SHA for 451a428 - Browse repository at this point
Copy the full SHA 451a428View commit details -
Switching to using docker_user until I figure this out.
Using DOCKER_USER in place of GEOFABRIK_API until the secret is successfully carried through to the test.
Configuration menu - View commit details
-
Copy full SHA for b027485 - Browse repository at this point
Copy the full SHA b027485View commit details
Commits on Oct 24, 2023
-
echoing the secret to see if it's being pulled at all
Configuration menu - View commit details
-
Copy full SHA for 2000144 - Browse repository at this point
Copy the full SHA 2000144View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3b93eb - Browse repository at this point
Copy the full SHA e3b93ebView commit details
Commits on Oct 26, 2023
-
Updating readme + Making sure the test still works (running on fork)
Adding the workflow status badge to the readme Running the test on my fork again before making further changes.
Configuration menu - View commit details
-
Copy full SHA for 0b9e455 - Browse repository at this point
Copy the full SHA 0b9e455View commit details -
Getting test to run on my branch again
???? Not sure why it didn't run last push.
Configuration menu - View commit details
-
Copy full SHA for ce2db01 - Browse repository at this point
Copy the full SHA ce2db01View commit details
Commits on Oct 30, 2023
-
Removing port 8080 (yet again!!)
Previous run of this test succeeded. Going to see what happens when I remove port 8080 as the only change (again)
Configuration menu - View commit details
-
Copy full SHA for 3bf52de - Browse repository at this point
Copy the full SHA 3bf52deView commit details
Commits on Oct 31, 2023
-
Re-adding port + setup changes
final changes (I hope!) to setup module + re-adding the port since the test did not work without it.
Configuration menu - View commit details
-
Copy full SHA for 8c2efb0 - Browse repository at this point
Copy the full SHA 8c2efb0View commit details -
Re-instating schedule (test will fail but that is expected)
Reverting to running test on schedule since (I think) everything else is done.
Configuration menu - View commit details
-
Copy full SHA for b7e0165 - Browse repository at this point
Copy the full SHA b7e0165View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5c35a0 - Browse repository at this point
Copy the full SHA f5c35a0View commit details
Commits on Nov 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for baf087a - Browse repository at this point
Copy the full SHA baf087aView commit details