Overpass key rename #971
Merged
Overpass key rename #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge server changes to figure out what's going on with overpass test
Originally, the overpass key was named OVERPASS_API throughout the code. My final change in the original PR was to rename the key to GEOFABRIK_OVERPASS_KEY. However, when naming the secret in the server actions repo, I wrongfully told shankari to name it GEOFABRIK_OVERPASS_KEY, rather than the OVERPASS_API that is functional in my fork. Renaming the secret when it's pulled from the github repo should fix this issue.
shankari
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the overpass key was named OVERPASS_API throughout the code. My final change in the original PR was to rename the key to GEOFABRIK_OVERPASS_KEY. However, when naming the secret in the server actions repo, I wrongfully told Shankari to name it GEOFABRIK_OVERPASS_KEY, rather than the OVERPASS_API that is functional in my fork/was coded into the yml file. Renaming the secret to GEOFABRIK_OVERPASS_KEY will make it compatible with the main server repo secret.