Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Always return an empty server_to_phone response #978

Merged
merged 1 commit into from
Sep 15, 2024

Commits on Aug 28, 2024

  1. ⚡️ Always return an empty server_to_phone response

    We don't actually use the server_to_phone response on the phone since we always
    retrieve data from the server. This comments out the data that is returned from
    the server so that we don't waste time reading data that we don't use.
    
    We still get the calls as a coarse ping to know that the app is installed and is
    working correctly, even if the user is not contributing data. But we don't burn
    up bandwidth reading unused data from the server.
    
    This cleanup is part of removing the NEW_DATA implicit intent
    e-mission/e-mission-docs#1079 (comment)
    
    Testing done:
    - Before: `08-27 17:26:02.802 11959 12158 I CommunicationHelper: Result Summary JSON = {"server_to_phone": [{"metadata": {"write_ts": 1687907246.5748034, "type": "document", "key": "diary/trips-2016-07-27"}, "data": [{"type": "FeatureCollection", "properties": {"source": "DwellSegmentat length 295649`
    - After:  `08-27 18:39:10.918 15925 16081 I CommunicationHelper: Result Summary JSON = {"server_to_phone": []}`
    shankari committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5c42542 View commit details
    Browse the repository at this point in the history