-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polishing Changes to the Config Automation #49
Conversation
added a field to the form and handled it in the parsing script
The repo that I based the issue -> JSON converted on does not have a license, at least at this moment, so my plan is to make sure that I link to the files I was adapting to make sure credit is still provided. |
In d39aa9a and b3e217f I copied the file from @sebastianbarry's repo into this PR, and updated the link to reflect where that sample file will rest in the The thing I don't have is the |
As far as I know, the |
There's some chance @asiripanich would have the original XML or Excel files for the trip-end-survey? It was many months ago so it's understandable if not. |
@AlirezaRa94 is
@AlirezaRa94, can you please help @JGreenlee with this? I think it can be easily exported from our Enketo account. |
@asiripanich |
@AlirezaRa94 yes, that matches the JSON file that we have, thank you! If you happen to also have the xlsx file that would be great, but if not no worries! |
I believe the full link I had was wrong
I think this is ready for review, unless we want to wait for more changes, but it includes:
Which covers the main goals of this PR. If we later find the |
id: admin_access | ||
attributes: | ||
label: Admin Access Emails | ||
description: Please enter a comman separated list of emails to which we will grant access to the admin dashboard. This will usually be a relatively short list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to have a limit of 3 users in the appendix. Maybe we can add a check for this number in the validation and limit it to less than 5?
@@ -1,4 +1,5 @@ | |||
# this action is based on the action by zachleat on github (github-issue-to-json-file) | |||
# https://github.com/zachleat/github-issue-to-json-file/blob/main/action.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abby-Wheelis in general, we cannot use copy that does not explicity have a LICENSE. We can "adapt" based on it if the changes are sufficiently large. You might want to check with legal on whether this meets that threshold.
Better than before, needs some check/follow-up on the LICENSE |
based on review comment - e-mission#49 (comment)
Changes to polish the config automation including:
/configs
filese-mission
(currently in @sebastianbarry's repo)(tasks from review of #46)