27 upgrade #107
Merged
27 upgrade #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation
|
Because of Cosmos SDK issue #9800 affecting all IBC chains at large, we will upgrade to SDK v0.42.9 this PR and PR #103 and look at a combined test. |
Add test-upg-0.2.0
haasted
requested changes
Aug 10, 2021
Makefile: separate testupg binary from build-linux Update README.md
haasted
approved these changes
Aug 12, 2021
Comment on lines
-104
to
-111
| // create/revoke issuer with both the former and the new authority | ||
| // former singlesig first | ||
| ok = nt.AuthCreatesIssuer(emcli, keystore.Authority, key1) | ||
| Expect(ok).To(BeTrue()) | ||
| _, success, err = emcli.AuthorityDestroyIssuer(keystore.Authority, key1) | ||
| Expect(success).To(BeTrue()) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
|
|
There was a problem hiding this comment.
How come this was removed? Did it get re-inserted somewhere else?
There was a problem hiding this comment.
We had talked about this before as a BDD fix after checking better for the error code---
3f786ac
There was a problem hiding this comment.
Likely the commit happened after this branch's creation and was merged in from dev
This was
linked to
issues
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readme.md
Please note this requires Docker rebuilding