Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4991: Fix improper array access in sc_signup_extended_user_fields #4993

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

Deltik
Copy link
Member

@Deltik Deltik commented Apr 16, 2023

Motivation and Context

Fixes: #4991

Description

varset() is not a language builtin that can handle unset array keys like isset() ? … : … can.

This change replaces a varset() with the isset() ? … : … style.

How Has This Been Tested?

/signup.php shows up now:

image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

@codeclimate
Copy link

codeclimate bot commented Apr 16, 2023

Code Climate has analyzed commit 1e601fb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 34.4% (-0.1% change).

View more on Code Climate.

@CaMer0n
Copy link
Member

CaMer0n commented Apr 21, 2023

Thank you!!

@CaMer0n CaMer0n merged commit 198d0cf into e107inc:master Apr 21, 2023
@Deltik Deltik deleted the fix/4991 branch April 23, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COPPA has to be enabled if Extended User Fields are set to display on Signup Page
2 participants