-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new zip coefficents for loads #2391
base: develop
Are you sure you want to change the base?
Conversation
…unpp got updated aswell
I see that you also have a build (3.11, 1) failure. Here I described the reason for the test failure: |
yeah, looks strange to me also. We made some changes to the mpc and ppc converters recently in PR #2347, but this bug didn't appear back then... Will let you know if we find out something |
I had a local test that was skipped because of the decorator (as far as I understand, if And I also think we need to look at when the migration to numpy 2.0 took place. Perhaps earlier versions weren't so strict. |
… format works fine. Should be replaced before release
…h42/pandapower into load_types_zip_coefficents
…h42/pandapower into load_types_zip_coefficents # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2391 +/- ##
===========================================
- Coverage 76.12% 76.12% -0.01%
===========================================
Files 284 284
Lines 33334 33400 +66
===========================================
+ Hits 25375 25425 +50
- Misses 7959 7975 +16 ☔ View full report in Codecov by Sentry. |
In pandapower the zip coefficients
const_i_percent
andconst_z_percent
were defined both for the P and the Q voltage dependency of loads. This PR separates them and introducesconst_i_p_percent
,const_i_q_percent
,const_z_p_percent
,const_z_q_percent
to allow separate P and Q voltage dependecies in the power flow.const_i_percent
andconst_z_percent
are replaced with these new columns.