Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new zip coefficents for loads #2391

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

pawellytaev
Copy link
Contributor

In pandapower the zip coefficients const_i_percent and const_z_percent were defined both for the P and the Q voltage dependency of loads. This PR separates them and introduces const_i_p_percent, const_i_q_percent, const_z_p_percent, const_z_q_percent to allow separate P and Q voltage dependecies in the power flow. const_i_percent and const_z_percent are replaced with these new columns.

@quant12345
Copy link
Contributor

quant12345 commented Sep 9, 2024

I see that you also have a build (3.11, 1) failure. Here I described the reason for the test failure: test_from_mpc.py. It is not clear why other builds pass tests?

@pawellytaev
Copy link
Contributor Author

pawellytaev commented Sep 9, 2024

yeah, looks strange to me also. We made some changes to the mpc and ppc converters recently in PR #2347, but this bug didn't appear back then... Will let you know if we find out something

@quant12345
Copy link
Contributor

quant12345 commented Sep 9, 2024

I had a local test that was skipped because of the decorator (as far as I understand, if matpowercaseframes is not installed, the test is skipped), so there was no error.
Anyway, in issues I suggested two options for fixing it. Let me know if a fix is ​​needed?

And I also think we need to look at when the migration to numpy 2.0 took place. Perhaps earlier versions weren't so strict.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 65.95745% with 32 lines in your changes missing coverage. Please review.

Project coverage is 76.12%. Comparing base (c570695) to head (d9ce881).

Files with missing lines Patch % Lines
...ower/converter/powerfactory/pp_import_functions.py 0.00% 25 Missing ⚠️
pandapower/create.py 85.71% 4 Missing ⚠️
pandapower/build_bus.py 90.00% 1 Missing ⚠️
...dapower/converter/powerfactory/export_pfd_to_pp.py 0.00% 1 Missing ⚠️
...ower/converter/powerfactory/pf_export_functions.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2391      +/-   ##
===========================================
- Coverage    76.12%   76.12%   -0.01%     
===========================================
  Files          284      284              
  Lines        33334    33400      +66     
===========================================
+ Hits         25375    25425      +50     
- Misses        7959     7975      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants