ignore unknown JSON object upon deserialization #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…model is unknown (no code found in code base), so that they are just stored as a dict in the network -> this way, a JSON serialized network can be loaded anyway without raising an exception
|
@dlohmeier can you also add a description into the Changelog and can you add a test which demonstrates / tests your improvement? Thanks! |
|
@vogt31337 changelog entries and test are added. Is it normal that the tests mostly fail atm? |
|
No, thats new. Seems to be sth. with Pandapipes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for json deserialization, it is now possible to ignore objects whose model is unknown (no code found in code base), so that they are just stored as a dict in the network -> this way, a JSON serialized network can be loaded anyway without raising an exception