Issues/2430 #2460
Merged
Issues/2430 #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switched to f-strings instead of % notation added some type hints and docstrings
renamed vars to small letters as per python naming convention
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2460 +/- ##
===========================================
+ Coverage 76.04% 76.27% +0.22%
===========================================
Files 282 282
Lines 33035 32944 -91
===========================================
+ Hits 25123 25127 +4
+ Misses 7912 7817 -95 ☔ View full report in Codecov by Sentry. |
reformatted file simplified some functions renamed some capitalized variables
vogt31337
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2430