Fix browser navigation for nav items #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was partly broken before introducing bookmarkable urls for events, and with that got more visible. E.g. this was now unexpected behavior: * Open https://e4f-hamburg.de/#event-06-12-23-e4f-vernetzungstreffen * Close the event / modal dialog * Click on "Kontakt" * scrolls as expected, but doesn't change the url hash (bug) * Click browser back * this now opens the event / modal dialog again (unexpected - caused by the previous issue, that clicking on "Kontakt" didn't change the url This fix is now based on https://github.com/kswedberg/jquery-smooth-scroll?tab=readme-ov-file#fnsmoothscroll and the mentioned back button support as shown in https://github.com/kswedberg/jquery-smooth-scroll/blob/master/demo/hashchange.html The same issue is described in mmistakes/minimal-mistakes#1767, which is related because our agency plugin also uses smooth scrolling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was partly broken before introducing bookmarkable urls for events, and with that got more visible. E.g. this was now unexpected behavior:
This fix is now based on
https://github.com/kswedberg/jquery-smooth-scroll?tab=readme-ov-file#fnsmoothscroll and the mentioned back button support as shown in https://github.com/kswedberg/jquery-smooth-scroll/blob/master/demo/hashchange.html
The same issue is described in
mmistakes/minimal-mistakes#1767, which is related because our agency plugin also uses smooth scrolling.
The links in organisation.md are now html links so that navigation works again.