ISSUE-133: follower forward add cluster verification #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongbinCheng
force-pushed
the
ISSUE-133
branch
from
e55a8fd to
764e3b5
Compare
HanSJTU
previously approved these changes
Dec 23, 2024
DongbinCheng
force-pushed
the
ISSUE-133
branch
from
764e3b5 to
7e458fa
Compare
HanSJTU
approved these changes
Dec 23, 2024
| if (clusterIter != clientMeta.end()) { | ||
| auto myClusterId = std::to_string(app::AppInfo::groupId()); | ||
| if ((clusterIter->second).compare(myClusterId.c_str()) != 0) { | ||
| SPDLOG_WARN("req clusterId does not match this clusterid {}, reject the request", myClusterId); |
There was a problem hiding this comment.
it's better to put req clusterId {} in the warning as well.
| @@ -71,6 +73,9 @@ class ForwardClientBase { | |||
| SPDLOG_WARN("ForwardClient for {} is nullptr", mPeerId); | |||
| return false; | |||
| } | |||
| // use lowercase letters(a-z), digits(0-9), hyphen(-) and underscores(_) in header key | |||
| call->mContext.AddMetadata("req_source", "forward"); | |||
There was a problem hiding this comment.
it's better to define "req_source", "forward" as static constexpr, and use them in both RequestCallData.h and ForwardClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.