Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EbayListbox): Add EbayListbox and use it with ListboxButton #381

Closed
wants to merge 2 commits into from

Conversation

HenriqueLimas
Copy link
Member

Description

  • Added EbayListbox component
  • Use makeup js packages for handling behavior and accessibility
  • Follow logic for EbayListboxButton same as marko implementation for consistency and accessibility considerations
  • Add missing features that was present in the marko version

Note, this is not a breaking change as the interface follows the exact same as before (as it can be seen in the storybook and tests)

@HenriqueLimas HenriqueLimas added bug Something isn't working enhancement New feature or request labels Dec 19, 2024
@HenriqueLimas HenriqueLimas self-assigned this Dec 19, 2024
@HenriqueLimas HenriqueLimas marked this pull request as draft December 19, 2024 17:12
@HenriqueLimas
Copy link
Member Author

There is one issue by using makeup-js:

  • For performance reason we don't render the list on first render, we do on click instead. The makeup-js expander used on listbox button needs to have the content to expand available in order to add the event listeners. Closing this PR for now, we will consider a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant