-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm audit fix: bump jspdf to 2.3.1 #419
Conversation
ghost
commented
Apr 1, 2021
@eKoopmans could we get this in? thanks! |
@eKoopmans @oschwede @drbeat @ovvn Could anyone of you please help prioritize this? |
Hi @ptanaji-cb , agreed this should be high priority. This is a change in major version for jsPDF, so I'll need a bit of testing before I'm confident that this doesn't break anything. |
@eKoopmans Any chance of getting this merged in and a pre-release published? It'd allow for easier testing and resolve the security problems for those with auditing requirements. |
+1 on this please. It's causing |
Hi, I'm actively working on this. It's unfortunately not an easy fix - changes in jsPDF 2.0.0+ are directly incompatible with the way html2pdf.js is built/bundled. It looks like it will be impossible to continue using Rollup. My next step is to switch to Webpack, if everything goes smoothly I'm hoping to have a fix merged in the next week, maybe two. |
Thanks @eKoopmans, really appreciate you taking the time for this. |
Hi @eKoopmans , The severity of jspdf dependency has risen to "High". Any update on this?
|
Hi everyone, v0.10.0 is now released with all security audits patched. You can access it by updating your dependencies to |
Awesome! thanks a lot @eKoopmans ! |