Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit fix: bump jspdf to 2.3.1 #419

Closed
wants to merge 1 commit into from
Closed

npm audit fix: bump jspdf to 2.3.1 #419

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 1, 2021

➜  html2pdf.js git:(security-audit-fix) ✗ npm audit

                       === npm audit security report ===

found 0 vulnerabilities
 in 462 scanned packages

@ghost ghost mentioned this pull request Apr 1, 2021
@ghost
Copy link
Author

ghost commented Apr 1, 2021

@eKoopmans could we get this in? thanks!

@ghost
Copy link
Author

ghost commented Apr 2, 2021

@eKoopmans @oschwede @drbeat @ovvn Could anyone of you please help prioritize this?

@eKoopmans
Copy link
Owner

Hi @ptanaji-cb , agreed this should be high priority. This is a change in major version for jsPDF, so I'll need a bit of testing before I'm confident that this doesn't break anything.

@shaliniM12
Copy link

Is there any status on this? As still getting the security issue for html2pdf.js

Screenshot 2021-05-17 at 2 11 56 PM

@Hawxy
Copy link

Hawxy commented Jun 30, 2021

@eKoopmans Any chance of getting this merged in and a pre-release published? It'd allow for easier testing and resolve the security problems for those with auditing requirements.

@samputer
Copy link

samputer commented Jul 9, 2021

+1 on this please. It's causing npm audit high severity alerts. Happy to help.

@eKoopmans
Copy link
Owner

Hi, I'm actively working on this. It's unfortunately not an easy fix - changes in jsPDF 2.0.0+ are directly incompatible with the way html2pdf.js is built/bundled. It looks like it will be impossible to continue using Rollup.

My next step is to switch to Webpack, if everything goes smoothly I'm hoping to have a fix merged in the next week, maybe two.

@samputer
Copy link

Thanks @eKoopmans, really appreciate you taking the time for this.

@ghost
Copy link
Author

ghost commented Aug 30, 2021

Hi @eKoopmans , The severity of jspdf dependency has risen to "High". Any update on this?

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Regular Expression Denial of Service (ReDoS)                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ jspdf                                                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=2.3.1                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ html2pdf.js                                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ html2pdf.js > jspdf                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1709                            │
└───────────────┴──────────────────────────────────────────────────────────────┘

@eKoopmans
Copy link
Owner

Hi everyone, v0.10.0 is now released with all security audits patched. You can access it by updating your dependencies to "html2pdf.js": "^0.10.0" - since the caret locks to a minor version for 0.x releases.

@ghost
Copy link
Author

ghost commented Aug 31, 2021

Awesome! thanks a lot @eKoopmans !

@ghost ghost deleted the security-audit-fix branch August 31, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants