Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove secure_wan test from the list of failing tests #462

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

Tempate
Copy link
Contributor

@Tempate Tempate commented Jul 18, 2024

The PR eProsima/Fast-DDS#5071 fixes a known issue in Fast-DDS's security over WAN. This issue made the secure_wan test fail, forcing us to place it in the list of failing tests (TEST_XFAIL). Since the test should now pass, we will remove it from the list of failing tests.

Merge after:

@Tempate Tempate changed the title Remove secure_wan test from the list of failing tests Remove secure_wan test from the list of failing tests Jul 18, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.24%. Comparing base (72f9b43) to head (b33822e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
- Coverage   31.14%   30.24%   -0.90%     
==========================================
  Files          16       16              
  Lines         594      562      -32     
  Branches      321      298      -23     
==========================================
- Hits          185      170      -15     
+ Misses        213      205       -8     
+ Partials      196      187       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Tempate and others added 2 commits September 18, 2024 10:38
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit 4980feb into main Sep 18, 2024
30 of 32 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the hotfix/security_wan branch September 18, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants